From: Andreas Dilger <adilger@clusterfs.com>
To: sho@tnes.nec.co.jp
Cc: cmm@us.ibm.com, jitendra@linsyssoft.com,
linux-kernel@vger.kernel.org, ext2-devel@lists.sourceforge.net
Subject: Re: [RFC][PATCH]add ext3_fileblk_t for file relative offset
Date: Fri, 30 Jun 2006 01:45:58 -0600 [thread overview]
Message-ID: <20060630074558.GP5318@schatzie.adilger.int> (raw)
In-Reply-To: <20060628223109sho@rifu.tnes.nec.co.jp>
On Jun 28, 2006 22:31 +0900, sho@tnes.nec.co.jp wrote:
> In Mingming's patch set, the single type `ext3_fsblk_t' deal with two
> different values, which are file relative offset and filesystem
> relative offset. I think it is confusing.
>
> Therefore I added "ext3_fileblk_t" for file relative offset.
> It makes maintenance easier and code clearer if file size
> needs to be larger.
> ext3_fileblk_t is unsigned long which is the maximum size of
> current type for file relative offset.
I think this is a good idea and support its inclusion into the patch set.
It also managed to find one (harmless) bug in the code.
> int ext3_get_blocks_handle(handle_t *handle, struct inode *inode,
> - sector_t iblock, unsigned long maxblocks,
> + ext3_fileblk_t iblock, unsigned long maxblocks,
iblock shouldn't have been a sector_t.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
prev parent reply other threads:[~2006-06-30 7:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-28 13:31 sho
2006-06-30 7:45 ` Andreas Dilger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060630074558.GP5318@schatzie.adilger.int \
--to=adilger@clusterfs.com \
--cc=cmm@us.ibm.com \
--cc=ext2-devel@lists.sourceforge.net \
--cc=jitendra@linsyssoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sho@tnes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®