mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johannes Stezenbach <js@linuxtv.org>
To: Parag Warudkar <kernel-stuff@comcast.net>
Cc: v4l-dvb-maintainer@linuxtv.org, linux-kernel@vger.kernel.org
Subject: Re: [v4l-dvb-maintainer] [PATCH] DVB Needs I2C Core
Date: Fri, 30 Jun 2006 22:36:30 +0200	[thread overview]
Message-ID: <20060630203630.GB12812@linuxtv.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0606300037010.9361@localhost.localdomain>

On Fri, Jun 30, 2006, Parag Warudkar wrote:
> DVB seems to be using i2c ( i2c_transfer() mainly ) all over the place but 
> it is possible to build DVB without having I2C selected. This results in 
> undefined symbol i2c_transfer in DVB module.
> 
> This patch makes I2C Core selected automatically if DVB is selected.
> Is it the right thing to do?

No. There are DVB drivers which don't use I2C
(e.g. some of the USB ones). dvb-core doesn't use
I2C at all.
I think most of the dependencies have been corrected
in git already.

Johannes

> --- linux-2.6.17/drivers/media/dvb/Kconfig.orig	2006-06-30 00:15:13.000000000 -0400
> +++ linux-2.6.17/drivers/media/dvb/Kconfig	2006-06-30 00:10:15.000000000 -0400
> @@ -7,6 +7,7 @@ menu "Digital Video Broadcasting Devices
>  config DVB
>  	bool "DVB For Linux"
>  	depends on NET && INET
> +	select I2C
>  	---help---
>  	  Support Digital Video Broadcasting hardware.  Enable this if you
>  	  own a DVB adapter and want to use it or if you compile Linux for

> _______________________________________________
> v4l-dvb-maintainer mailing list
> v4l-dvb-maintainer@linuxtv.org
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer


      reply	other threads:[~2006-06-30 20:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-30  4:41 Parag Warudkar
2006-06-30 20:36 ` Johannes Stezenbach [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060630203630.GB12812@linuxtv.org \
    --to=js@linuxtv.org \
    --cc=kernel-stuff@comcast.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=v4l-dvb-maintainer@linuxtv.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®