From: Sam Ravnborg <sam@ravnborg.org>
To: Milton Miller <miltonm@bga.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [KBUILD] allow any PHONY in if_changed_dep
Date: Sat, 1 Jul 2006 11:39:27 +0200 [thread overview]
Message-ID: <20060701093927.GA25738@mars.ravnborg.org> (raw)
In-Reply-To: <200607010916.k619GuxT005076@sullivan.realtime.net>
On Sat, Jul 01, 2006 at 04:16:56AM -0500, Milton Miller wrote:
> While all the if_changed family filter $(PHONY) from the list of newer
> files, if_changed_dep was only filtering FORCE from the list of all
> dependents. This resulted in forced recompile every time.
I see where you are heading with this. But on the principle of minimal
suprise this is not good. Why does it not include file.o in the link
when I mark it phony?
The root cause is buried in the powerpc/boot/Makefile restructuring.
I do not see what is wrong with current approch if you do a simple
s/cmd/if_changed/g and then assign targets += <relevant targets>
You need to post a full diff of the Makefile before I can give better
feedback.
Sam
next prev parent reply other threads:[~2006-07-01 9:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-01 9:16 Milton Miller
2006-07-01 9:39 ` Sam Ravnborg [this message]
2006-07-01 23:36 ` Milton Miller
[not found] ` <kexec-zImage-try2@bga.com>
2006-07-01 23:46 ` [3/5][POWERPC] boot: use more Kbuild rules Milton Miller
[not found] <200607051502.k65F28bO019554@sullivan.realtime.net>
2006-07-05 15:12 ` [KBUILD] allow any PHONY in if_changed_dep Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060701093927.GA25738@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miltonm@bga.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®