mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chuck Ebbert <76306.1226@compuserve.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: pageexec <pageexec@freemail.hu>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Arjan van de Ven <arjan@infradead.org>,
	Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] i386: clean up user_mode() use
Date: Sun, 2 Jul 2006 16:10:55 -0400	[thread overview]
Message-ID: <200607021612_MC3-1-C3FD-CC89@compuserve.com> (raw)

In-Reply-To: <20060702133718.GA27549@elte.hu>

On Sun, 2 Jul 2006 15:37:18 +0200, Ingo Molnar wrote:

> > to avoid such mistakes in the future, the suggested solution is to 
> > make user_mode() on i386 consistent with the generic expectation and 
> > make it detect any user mode execution context, that is, it should 
> > take the role of user_mode_vm() and a new user_mode_novm() is 
> > introduced for the i386 specific cases where v86 mode can be excluded. 
> > in short, the patch simply does a
> > 
> >   user_mode_vm -> user_mode
> >   user_mode    -> user_mode_novm
> > 
> > substitution as appropriate.
> > 
> > Signed-off-by: PaX Team <pageexec@freemail.hu>
> 
> agreed!
> 
> Acked-by: Ingo Molnar <mingo@elte.hu>

Please make that second one

        user_mode_novm86

Otherwise people might think it means "user mode no virtual memory."

-- 
Chuck
 "You can't read a newspaper if you can't read."  --George W. Bush

             reply	other threads:[~2006-07-02 20:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-02 20:10 Chuck Ebbert [this message]
2006-07-02 20:42 ` Linus Torvalds
     [not found] ` <44A85518.24327.2FBD646A@pageexec.freemail.hu>
2006-07-02 21:36   ` Linus Torvalds
2006-07-03  4:36     ` Ingo Molnar
     [not found] <44A7BE17.23657.2D6F894E@pageexec.freemail.hu>
2006-07-02 13:37 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200607021612_MC3-1-C3FD-CC89@compuserve.com \
    --to=76306.1226@compuserve.com \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=pageexec@freemail.hu \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome