From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750749AbWGCNuE (ORCPT ); Mon, 3 Jul 2006 09:50:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750829AbWGCNuD (ORCPT ); Mon, 3 Jul 2006 09:50:03 -0400 Received: from caramon.arm.linux.org.uk ([212.18.232.186]:54281 "EHLO caramon.arm.linux.org.uk") by vger.kernel.org with ESMTP id S1750749AbWGCNuB (ORCPT ); Mon, 3 Jul 2006 09:50:01 -0400 Date: Mon, 3 Jul 2006 14:49:38 +0100 From: Russell King To: "Randy.Dunlap" Cc: akpm@osdl.org, rjw@sisk.pl, davej@redhat.com, linux-kernel@vger.kernel.org, sekharan@us.ibm.com, rusty@rustcorp.com.au, sam@ravnborg.org Subject: Re: 2.6.17-mm2 Message-ID: <20060703134937.GB31274@flint.arm.linux.org.uk> Mail-Followup-To: "Randy.Dunlap" , akpm@osdl.org, rjw@sisk.pl, davej@redhat.com, linux-kernel@vger.kernel.org, sekharan@us.ibm.com, rusty@rustcorp.com.au, sam@ravnborg.org References: <20060624061914.202fbfb5.akpm@osdl.org> <20060624172014.GB26273@redhat.com> <20060624143440.0931b4f1.akpm@osdl.org> <200606251051.55355.rjw@sisk.pl> <20060625032243.fcce9e2e.akpm@osdl.org> <20060625081610.9b0a775a.akpm@osdl.org> <20060630003813.e1003a93.rdunlap@xenotime.net> <20060702101146.GA26924@flint.arm.linux.org.uk> <20060702225024.73c7fe91.rdunlap@xenotime.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060702225024.73c7fe91.rdunlap@xenotime.net> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 02, 2006 at 10:50:24PM -0700, Randy.Dunlap wrote: > On Sun, 2 Jul 2006 11:11:46 +0100 Russell King wrote: > > On Fri, Jun 30, 2006 at 12:38:13AM -0700, Randy.Dunlap wrote: > > > Until modpost (or whatever) can do this, here are a few that > > > a shell script has found for me by examing source code only -- > > > may contain some false reports: > > > > ... > > > ./arch/arm/mach-imx/generic.c:196:EXPORT_SYMBOL(imx_set_mmc_info); > > > ./arch/arm/mach-imx/generic.c:192:void __init imx_set_mmc_info(struct imxmmc_platform_data *info) > > > > > > ./arch/arm/mach-imx/generic.c:204:EXPORT_SYMBOL(set_imx_fb_info); > > > ./arch/arm/mach-imx/generic.c:200:void __init set_imx_fb_info(struct imxfb_mach_info *hard_imx_fb_info) > > > > > These are definitely buggy. > > Um, well, I could blindly remove those __init sections, but in > looking at the code, set_imx_fb_info() is not ever used, and > imx_set_mmc_info() is called from some __init code... > > It looks like this code can only be built-in, not as a loadable > module. (so someone who knows it should jump in here) > If that's correct, then the EXPORT_SYMBOL() isn't even needed > and the function can remain as __init (right?). Since they're being used to set the platform data for devices, which are registered during the init time, they should definitely only be called early on during init - otherwise you're potentially changing data which drivers expect to be static. So the exports should go. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core