Re: [PATCH 1/2] batch-write.patch

[Andrew Morton <akpm@osdl.org>]

On Tue, 04 Jul 2006 10:44:13 -0700
Hans Reiser <reiser@namesys.com> wrote:

> Christoph Hellwig wrote:
> 
> >On Tue, Jul 04, 2006 at 03:12:56PM +0400, Vladimir V. Saveliev wrote:
> >  
> >
> >>>Should this be an address_space_operation or a file_operation?
> >>>
> >>>      
> >>>
> >>I was seeking to be minimal in my changes to the philosophy of the code.
> >>So, it was an address_space operation. Now it is a file operation.
> >>    
> >>
> >
> >It definitly should not be a file_operation! It works at the address_space
> >not the much higher file level.  Maybe all three should become callbacks
> >for the generic write routines, but that's left for the future.
> >
> >
> >  
> >
> I don't have a commitment to one way or the other, probably because
> there are some things that are unclear in my mind.  Could you help me
> with them?  Can you define what is the address space vs. the file level
> please?  It is odd to be asking such a basic question, but these things
> are genuinely unclear to me.  If the use of something varies according
> to the file, is it a file method?  What things vary according to address
> space and not according to file?  Should things that vary according to
> address space be address space ops and things that vary according to
> file be file ops?  If that logic seems valid, should a lot more be changed?
> 
> Oh, and Andrew, while such things are discussed, could you just pick one
> way or the other and let the patch go in?
> 

I wasn't sure, which was I asked rather than suggested..

Looking closer, yes I agree with Christoph, sorry.  It's called at the same
level as ->prepare_write/commit_write so if there's any logic to this, it's
logical that batched_write be an a_op too.