mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@mellanox.co.il>
To: Zach Brown <zach.brown@oracle.com>
Cc: Andrew Morton <akpm@osdl.org>, Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org, openib-general@openib.org,
	Arjan van de Ven <arjan@infradead.org>
Subject: Re: [openib-general] [PATCH] mthca: initialize send and receive queue locks separately
Date: Tue, 4 Jul 2006 19:52:34 +0300	[thread overview]
Message-ID: <20060704165234.GA5935@mellanox.co.il> (raw)
In-Reply-To: <44AA9999.3060308@oracle.com>

Quoting r. Zach Brown <zach.brown@oracle.com>:
> Is that just a side-effect of
> relying on mthca_wq_init() to reset the non-lock members?

Yes.


> If you're
> concerned about microoptimization it seems like this could be avoided.

This is off the fast path so I think Roland's idea was we should only care
about code size. But might be worth thinking this over, anyway. Thanks!

-- 
MST

  reply	other threads:[~2006-07-04 17:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-03 22:50 Zach Brown
2006-07-04  7:03 ` Michael S. Tsirkin
2006-07-04  8:56   ` Ingo Molnar
2006-07-04  9:42     ` Michael S. Tsirkin
2006-07-04 11:56       ` Ingo Molnar
2006-07-04 12:52         ` Michael S. Tsirkin
2006-07-26  6:26         ` [PATCH] lockdep: don't pull in includes when lockdep disabled Michael S. Tsirkin
2006-07-26  6:33           ` Arjan van de Ven
2006-07-26  6:43             ` Michael S. Tsirkin
2006-07-26  7:13             ` Alexey Dobriyan
2006-07-04 16:38   ` [openib-general] [PATCH] mthca: initialize send and receive queue locks separately Zach Brown
2006-07-04 16:52     ` Michael S. Tsirkin [this message]
2006-07-04 20:39     ` Roland Dreier
2006-07-05  3:07       ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060704165234.GA5935@mellanox.co.il \
    --to=mst@mellanox.co.il \
    --cc=akpm@osdl.org \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=openib-general@openib.org \
    --cc=zach.brown@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®