From: Mikael Pettersson <mikpe@it.uu.se>
To: davem@davemloft.net
Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org
Subject: [PATCH 2.6.17 sparc64] fix stack overflow checking in modular non-SMP kernels
Date: Tue, 4 Jul 2006 22:10:11 +0200 (MEST) [thread overview]
Message-ID: <200607042010.k64KABmC011107@harpo.it.uu.se> (raw)
The sparc64 kernel's EXPORT_SYMBOL(_mcount) is inside an
#ifdef CONFIG_SMP. This breaks modules in non-SMP kernels
built with stack overflow checking (CONFIG_STACK_DEBUG=y),
as modules_install reports:
WARNING: /lib/modules/2.6.17/kernel/drivers/ide/ide-cd.ko needs unknown symbol _mcount
Trivially fixed by moving EXPORT_SYMBOL(_mcount) outside of
the #ifdef CONFIG_SMP.
Signed-off-by: Mikael Pettersson <mikpe@it.uu.se>
--- linux-2.6.17/arch/sparc64/kernel/sparc64_ksyms.c.~1~ 2006-06-18 12:13:02.000000000 +0200
+++ linux-2.6.17/arch/sparc64/kernel/sparc64_ksyms.c 2006-07-04 20:41:07.000000000 +0200
@@ -128,11 +128,6 @@ EXPORT_SYMBOL(__write_trylock);
/* Hard IRQ locking */
EXPORT_SYMBOL(synchronize_irq);
-#if defined(CONFIG_MCOUNT)
-extern void _mcount(void);
-EXPORT_SYMBOL(_mcount);
-#endif
-
/* CPU online map and active count. */
EXPORT_SYMBOL(cpu_online_map);
EXPORT_SYMBOL(phys_cpu_present_map);
@@ -140,6 +135,11 @@ EXPORT_SYMBOL(phys_cpu_present_map);
EXPORT_SYMBOL(smp_call_function);
#endif /* CONFIG_SMP */
+#if defined(CONFIG_MCOUNT)
+extern void _mcount(void);
+EXPORT_SYMBOL(_mcount);
+#endif
+
EXPORT_SYMBOL(sparc64_get_clock_tick);
/* semaphores */
next reply other threads:[~2006-07-04 20:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-04 20:10 Mikael Pettersson [this message]
2006-07-06 3:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200607042010.k64KABmC011107@harpo.it.uu.se \
--to=mikpe@it.uu.se \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®