From: Brent Casavant <bcasavan@sgi.com>
To: Dave Jones <davej@redhat.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: remove devinit from ioc4 pci_driver
Date: Wed, 5 Jul 2006 10:56:28 -0500 (CDT) [thread overview]
Message-ID: <20060705105544.C93671@pkunk.americas.sgi.com> (raw)
In-Reply-To: <20060628193313.GA22146@redhat.com>
It's a bit late and after-the-fact as I was on vacation, however:
Acked-by: Brent Casavant <bcasavan@sgi.com>
On Wed, 28 Jun 2006, Dave Jones wrote:
> Documention/pci.txt states..
> "The struct pci_driver shouldn't be marked with any of these tags."
> (Referring to __devinit and friends).
>
> Signed-off-by: Dave Jones <davej@redhat.com>
>
> --- linux-2.6/drivers/sn/ioc4.c~ 2006-06-28 15:31:26.000000000 -0400
> +++ linux-2.6/drivers/sn/ioc4.c 2006-06-28 15:32:09.000000000 -0400
> @@ -438,7 +438,7 @@ static struct pci_device_id ioc4_id_tabl
> {0}
> };
>
> -static struct pci_driver __devinitdata ioc4_driver = {
> +static struct pci_driver ioc4_driver = {
> .name = "IOC4",
> .id_table = ioc4_id_table,
> .probe = ioc4_probe,
>
> --
> http://www.codemonkey.org.uk
>
--
Brent Casavant All music is folk music. I ain't
bcasavan@sgi.com never heard a horse sing a song.
Silicon Graphics, Inc. -- Louis Armstrong
prev parent reply other threads:[~2006-07-05 15:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-28 19:33 Dave Jones
2006-07-05 15:56 ` Brent Casavant [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060705105544.C93671@pkunk.americas.sgi.com \
--to=bcasavan@sgi.com \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®