From: Andrew Morton <akpm@osdl.org>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@osdl.org, bernds_cb1@t-online.de, sam@ravnborg.org,
dhowells@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] FDPIC: Fix FDPIC compile errors [try #2]
Date: Wed, 5 Jul 2006 12:41:42 -0700 [thread overview]
Message-ID: <20060705124142.7bec7597.akpm@osdl.org> (raw)
In-Reply-To: <20060705175443.12594.30741.stgit@warthog.cambridge.redhat.com>
David Howells <dhowells@redhat.com> wrote:
>
> From: David Howells <dhowells@redhat.com>
>
> The attached patch fixes FDPIC compile errors
>
> Signed-Off-By: David Howells <dhowells@redhat.com>
> ---
>
> fs/binfmt_elf_fdpic.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/fs/binfmt_elf_fdpic.c b/fs/binfmt_elf_fdpic.c
> index eba4e23..07624b9 100644
> --- a/fs/binfmt_elf_fdpic.c
> +++ b/fs/binfmt_elf_fdpic.c
> @@ -459,6 +459,7 @@ #endif
> */
> hwcap = ELF_HWCAP;
> k_platform = ELF_PLATFORM;
> + u_platform = NULL;
>
> if (k_platform) {
> platform_len = strlen(k_platform) + 1;
Methinks it actually fixes a warning, which was promoted to an error by
-Werror. Which was fixed by adding an unneeded assignment, all becasue gcc
is dumb.
next prev parent reply other threads:[~2006-07-05 19:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-05 17:54 [PATCH 0/5] Fix FRV, ELF-FDPIC and NOMMU stuff " David Howells
2006-07-05 17:54 ` [PATCH 1/5] FDPIC: Fix FDPIC compile errors " David Howells
2006-07-05 19:41 ` Andrew Morton [this message]
2006-07-05 20:48 ` Sam Ravnborg
2006-07-05 17:54 ` [PATCH 2/5] FRV: Fix FRV arch " David Howells
2006-07-05 17:54 ` [PATCH 3/5] NOMMU: Fix execution off of ramfs with mmap() " David Howells
2006-07-05 17:54 ` [PATCH 4/5] [PATCH] FDPIC: Add coredump capability for the ELF-FDPIC binfmt " David Howells
2006-07-05 17:54 ` [PATCH 5/5] FRV: Introduce asm-offsets for FRV arch " David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060705124142.7bec7597.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=bernds_cb1@t-online.de \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome