From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965147AbWGFC6m (ORCPT ); Wed, 5 Jul 2006 22:58:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965143AbWGFC6m (ORCPT ); Wed, 5 Jul 2006 22:58:42 -0400 Received: from xenotime.net ([66.160.160.81]:36011 "HELO xenotime.net") by vger.kernel.org with SMTP id S965145AbWGFC6l (ORCPT ); Wed, 5 Jul 2006 22:58:41 -0400 Date: Wed, 5 Jul 2006 20:01:26 -0700 From: "Randy.Dunlap" To: "Thomas Tuttle" Cc: linux-kernel@vger.kernel.org Subject: Re: PATCH: Create new LED trigger for CPU activity (ledtrig-cpu) (UPDATED) Message-Id: <20060705200126.48f83ec0.rdunlap@xenotime.net> In-Reply-To: References: Organization: YPO4 X-Mailer: Sylpheed version 2.2.6 (GTK+ 2.8.3; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 5 Jul 2006 22:48:17 -0400 Thomas Tuttle wrote: > Here is a new version of the patch, incorporating code style tips from > Randy Dunlap , and based on 2.6.17-git25, rather > than 2.6.17.1. > > I noticed that there's a Heartbeat LED trigger in the git version. I > hope this isn't too similar. I missed at least one thing: Don't #include That is done automatically now by Kbuild. Source files should not do it. (you could wait to see if there are other comments. :) --- ~Randy