On July 06 at 00:39 EDT, Andrew Morton hastily scribbled:
> On Wed, 5 Jul 2006 22:48:17 -0400
> "Thomas Tuttle" <thinkinginbinary@gmail.com> wrote:

Omigod, Andrew Morton replied to my email.  Cool.  Linux rocks.

> > Here is a new version of the patch, incorporating code style tips from
> > Randy Dunlap <rdunlap@xenotime.net>, and based on 2.6.17-git25, rather
> > than 2.6.17.1.
> > 
> > I noticed that there's a Heartbeat LED trigger in the git version.  I
> > hope this isn't too similar.
> > 
>
> <snip>
> 
> waaaaaaaaaaay too many config options.  Make up your mind, man ;)

Okay, this new patch includes user and system, excludes iowait, and
makes nice configurable by a boolean module parameter called
include_nice, with the default being to exclude nice time.

> > +cputime64_t last_cputime;
> static.
Done.

> > +static void __exit ledtrig_cpu_exit(void)
> > +{
> > +	del_timer(&ledtrig_cpu_timer);
> del_timer_sync().
Done.

I also made the trigger track the last state of the LED, and avoid
sending a trigger event unless the state has actually changed.  And I
made it turn off the LED when the trigger is unloaded.

--Thomas Tuttle