From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751068AbWGFXuE (ORCPT ); Thu, 6 Jul 2006 19:50:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751077AbWGFXuE (ORCPT ); Thu, 6 Jul 2006 19:50:04 -0400 Received: from 1wt.eu ([62.212.114.60]:58377 "EHLO 1wt.eu") by vger.kernel.org with ESMTP id S1751068AbWGFXuD (ORCPT ); Thu, 6 Jul 2006 19:50:03 -0400 Date: Fri, 7 Jul 2006 01:49:18 +0200 From: Willy Tarreau To: Greg KH Cc: "Scott J. Harmon" , linux-kernel@vger.kernel.org, stable@kernel.org, torvalds@osdl.org, Andrew Morton Subject: Re: Linux 2.6.17.4 Message-ID: <20060706234918.GB2037@1wt.eu> References: <20060706222704.GB2946@kroah.com> <20060706222841.GD2946@kroah.com> <44AD9229.6010301@ksu.edu> <20060706224614.GA3520@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060706224614.GA3520@suse.de> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 06, 2006 at 03:46:14PM -0700, Greg KH wrote: > On Thu, Jul 06, 2006 at 05:43:53PM -0500, Scott J. Harmon wrote: > > Greg KH wrote: > > > diff --git a/Makefile b/Makefile > > > index 8c72521..abcf2d7 100644 > > > --- a/Makefile > > > +++ b/Makefile > > > @@ -1,7 +1,7 @@ > > > VERSION = 2 > > > PATCHLEVEL = 6 > > > SUBLEVEL = 17 > > > -EXTRAVERSION = .3 > > > +EXTRAVERSION = .4 > > > NAME=Crazed Snow-Weasel > > > > > > # *DOCUMENTATION* > > > diff --git a/kernel/sys.c b/kernel/sys.c > > > index 0b6ec0e..59273f7 100644 > > > --- a/kernel/sys.c > > > +++ b/kernel/sys.c > > > @@ -1991,7 +1991,7 @@ asmlinkage long sys_prctl(int option, un > > > error = current->mm->dumpable; > > > break; > > > case PR_SET_DUMPABLE: > > > - if (arg2 < 0 || arg2 > 2) { > > > + if (arg2 < 0 || arg2 > 1) { > > > error = -EINVAL; > > > break; > > > } > > Just curious as to why this isn't just > > ... > > if (arg2 != 1) { > > ... > > Because that would be incorrect :) Interestingly, 2.4 tests (arg2 !=0 && arg2 != 1) so from the code changes above, it looks like the value 2 was added on purpose, but for what ? Maybe the fix is not really correct yet ? Cheers, Willy > > thanks, > > greg k-h > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/