From: Andrew Morton <akpm@osdl.org>
To: "Randy.Dunlap" <rdunlap@xenotime.net>
Cc: linux-kernel@vger.kernel.org, greg@kroah.com, davej@codemonkey.org.uk
Subject: Re: [PATCH] PCIE: create sysfs directory on first use
Date: Fri, 7 Jul 2006 17:10:15 -0700 [thread overview]
Message-ID: <20060707171015.688e4011.akpm@osdl.org> (raw)
In-Reply-To: <20060707165238.337c7a4a.rdunlap@xenotime.net>
"Randy.Dunlap" <rdunlap@xenotime.net> wrote:
>
> + if (!pcie_dev_registered)
> + pcie_port_bus_register();
> +
Wonderful. You're forced to drop all error checking on the floor because
pcie_port_bus_register() assumes that nobody could possibly ever be
interested in actually checking for errors.
What happens if the bus_register() fails and the driver cheerily blunders
along assuming that pcie_port_bus_type is registered? Incomprehensible lkml
oops reports, I'm suspecting..
Let's start stamping this out. Could I please ask that you first prepare a
patch which fixes pcie_port_bus_register() (and mark it __must_check) and
then let's actually, like, check for errors?
next prev parent reply other threads:[~2006-07-08 0:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-07 23:52 Randy.Dunlap
2006-07-08 0:07 ` Valdis.Kletnieks
2006-07-08 0:10 ` Andrew Morton [this message]
2006-07-08 0:17 ` Randy.Dunlap
2006-07-09 5:58 ` [PATCH] PCIE: check and return bus_register errors Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060707171015.688e4011.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=davej@codemonkey.org.uk \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®