From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932263AbWGGTHn (ORCPT ); Fri, 7 Jul 2006 15:07:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932231AbWGGTHn (ORCPT ); Fri, 7 Jul 2006 15:07:43 -0400 Received: from mx1.redhat.com ([66.187.233.31]:40160 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S932263AbWGGTHm (ORCPT ); Fri, 7 Jul 2006 15:07:42 -0400 Date: Fri, 7 Jul 2006 15:07:39 -0400 From: Dave Jones To: linux-kernel@vger.kernel.org Cc: se.witt@gmx.de Subject: Re: lost cpufreq (Re: Linux v2.6.18-rc1) Message-ID: <20060707190739.GB5818@redhat.com> Mail-Followup-To: Dave Jones , linux-kernel@vger.kernel.org, se.witt@gmx.de References: <20060707175239.GB7648@irc.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060707175239.GB7648@irc.pl> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 07, 2006 at 07:52:39PM +0200, Tomasz Torcz wrote: > On Wed, Jul 05, 2006 at 09:26:35PM -0700, Linus Torvalds wrote: > > > > Ok, > > the merge window for 2.6.18 is closed, and -rc1 is out there > > ... and cpufreq-nforce2.ko fails to work. Module can't be loaded: > FATAL: Error inserting cpufreq_nforce2 > (/lib/modules/2.6.18-rc1/kernel/arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.ko): > Device or resource busy > > Here's relevant difference between dmesg of 2.6.17 and 2.6.18-rc1: > > @@ -244,7 +240,6 @@ > lp: driver loaded but no devices found > cpufreq: Detected nForce2 chipset revision C1 > cpufreq: FSB changing is maybe unstable and can lead to crashes and data loss. > -cpufreq: FSB currently at 165 MHz, FID 10.5 > usbcore: registered new driver usbfs > usbcore: registered new driver hub Does it work again if you apply this patch with -R ? Dave diff --git a/arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.c b/arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.c index f275e0d..0d49d73 100644 --- a/arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.c +++ b/arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.c @@ -90,7 +90,7 @@ static int nforce2_calc_pll(unsigned int /* Try to calculate multiplier and divider up to 4 times */ while (((mul == 0) || (div == 0)) && (tried <= 3)) { - for (xdiv = 1; xdiv <= 0x80; xdiv++) + for (xdiv = 2; xdiv <= 0x80; xdiv++) for (xmul = 1; xmul <= 0xfe; xmul++) if (nforce2_calc_fsb(NFORCE2_PLL(xmul, xdiv)) == fsb + tried) { -- http://www.codemonkey.org.uk