Re: Compile Error on 2.6.17-mm6

[Adrian Bunk <bunk@stusta.de>]

On Sat, Jul 08, 2006 at 05:43:47PM -0700, Andrew Morton wrote:
> On Fri, 7 Jul 2006 22:22:16 -0400
> Matt Reuther <mreuther@umich.edu> wrote:
> 
> > Here is the error:
> >   CHK     include/linux/compile.h
> >   UPD     include/linux/compile.h
> >   CC      init/version.o
> >   LD      init/built-in.o
> >   LD      .tmp_vmlinux1
> > arch/i386/kernel/built-in.o(.text+0xe282): In function 
> > `cpu_request_microcode':
> > arch/i386/kernel/microcode.c:544: undefined reference to `request_firmware'
> > arch/i386/kernel/built-in.o(.text+0xe304):arch/i386/kernel/microcode.c:573: 
> > undefined reference to `release_firmware'
> 
> CONFIG_FW_LOADER=m
> CONFIG_MICROCODE=y
> 
> So
> 
> config MICROCODE
> 	tristate "/dev/cpu/microcode - Intel IA32 CPU microcode support"
> 	depends on FW_LOADER
> 
> is not sufficient.

This should be sufficient and prevent the above problem (it was only a 
problem if MICROCODE was a bool).

> There's a fix for this, but I cannot remember what it
> is.  Help.

The above dependency is technically correct, but since FW_LOADER is only 
an internal helper variable the more user friendly solution is:

config MICROCODE
	tristate "/dev/cpu/microcode - Intel IA32 CPU microcode support"
	select FW_LOADER

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed