From: Nathan Scott <nathans@sgi.com>
To: Milton Miller <miltonm@bga.com>
Cc: Jens Axboe <axboe@suse.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blktrace: readahead support
Date: Mon, 10 Jul 2006 15:53:21 +1000 [thread overview]
Message-ID: <20060710155321.B1675237@wobbly.melbourne.sgi.com> (raw)
In-Reply-To: <200607100546.k6A5k3qU049783@sullivan.realtime.net>; from miltonm@bga.com on Mon, Jul 10, 2006 at 12:46:03AM -0500
On Mon, Jul 10, 2006 at 12:46:03AM -0500, Milton Miller wrote:
> > +#define trace_ahead_bit(rw) \
> > + (((rw) & (1 << BIO_RW_AHEAD)) << (BIO_RW_AHEAD - 0))
> ...
> I think the shift should be << (2 - BIO_RW_AHEAD).
Quite possibly. As long as it ends up in slot 4 in that array still..
which it will.
cheers.
--
Nathan
next prev parent reply other threads:[~2006-07-10 5:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-10 5:46 Milton Miller
2006-07-10 5:53 ` Nathan Scott [this message]
2006-07-10 6:24 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060710155321.B1675237@wobbly.melbourne.sgi.com \
--to=nathans@sgi.com \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=miltonm@bga.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome