From: Andrew Morton <akpm@osdl.org>
To: "Antonino A. Daplas" <adaplas@gmail.com>
Cc: rdunlap@xenotime.net, mreuther@umich.edu,
linux-kernel@vger.kernel.org, zap@homelink.ru
Subject: Re: [PATCH] backlight: lcd: Remove dependency from the framebuffer layer
Date: Tue, 11 Jul 2006 03:28:17 -0700 [thread overview]
Message-ID: <20060711032817.94c78ae0.akpm@osdl.org> (raw)
In-Reply-To: <44B34D68.3080602@gmail.com>
On Tue, 11 Jul 2006 15:04:08 +0800
"Antonino A. Daplas" <adaplas@gmail.com> wrote:
> +#if defined(CONFIG_FB) || (defined(CONFIG_FB_MODULE) && \
> + defined(CONFIG_BACKLIGHT_CLASS_DEVICE_MODULE))
Peeking at CONFIG_FB_MODULE like this is considered sinful.
<tries to remember why>
Because someone might build a CONFIG_FB=n, CONFIG_FB_MODULE=n kernel, then
later build the fbdev module for that kernel only to find that the
backlight driver doesn't know that the fbdev module is available.
Or something like that. It's pretty contrived, and I really doubt that
anyone's going to try to cobble together a kernel like that.
Or maybe there's a better reason...
next prev parent reply other threads:[~2006-07-11 10:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-10 12:32 Depmod errors on 2.6.17.4/2.6.18-rc1/2.6.18-rc1-mm1 Matt Reuther
2006-07-10 13:02 ` Antonino A. Daplas
2006-07-10 15:32 ` Matt Reuther
2006-07-10 15:58 ` Antonino A. Daplas
2006-07-11 3:27 ` Matt Reuther
2006-07-11 4:52 ` [PATCH] appledisplay/backlight (Depmod errors on 2.6.17.4/2.6.18-rc1/2.6.18-rc1-mm1) Randy.Dunlap
2006-07-11 6:54 ` [PATCH] backlight: lcd: Remove dependency from the framebuffer layer Antonino A. Daplas
2006-07-11 7:04 ` Antonino A. Daplas
2006-07-11 10:28 ` Andrew Morton [this message]
2006-07-11 10:36 ` Antonino A. Daplas
2006-07-11 12:45 ` [PATCH] fbdev: Statically link the framebuffer notification functions Antonino A. Daplas
2006-07-11 12:50 ` Antonino A. Daplas
2006-07-11 13:21 ` Jon Smirl
2006-07-11 13:40 ` Antonino A. Daplas
2006-07-11 13:46 ` Jon Smirl
2006-07-11 14:34 ` Antonino A. Daplas
2006-07-11 14:43 ` Jon Smirl
2006-07-11 14:50 ` Antonino A. Daplas
2006-07-11 15:03 ` Jon Smirl
2006-07-11 15:21 ` Antonino A. Daplas
2006-07-11 5:16 ` [PATCH] sound-miro unknown symbols (Depmod errors on 2.6.17.4/2.6.18-rc1/2.6.18-rc1-mm1) Randy.Dunlap
2006-07-11 6:56 ` Depmod errors on 2.6.17.4/2.6.18-rc1/2.6.18-rc1-mm1 Antonino A. Daplas
2006-07-11 11:20 ` Matt Reuther
2006-07-11 13:12 ` Antonino A. Daplas
2006-07-12 12:41 ` Matt Reuther
2006-07-12 15:25 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060711032817.94c78ae0.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=adaplas@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mreuther@umich.edu \
--cc=rdunlap@xenotime.net \
--cc=zap@homelink.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome