From: jfannin@gmail.com (Joseph Fannin)
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@osdl.org>, Joseph Fannin <jfannin@gmail.com>,
linux-kernel@vger.kernel.org, arjan@infradead.org,
John Stultz <johnstul@us.ibm.com>
Subject: Re: [LOCKDEP] 2.6.18-rc1: inconsistent {hardirq-on-W} -> {in-hardirq-W} usage
Date: Tue, 11 Jul 2006 01:11:08 -0400 [thread overview]
Message-ID: <20060711051108.GA13574@nineveh.rivenstone.net> (raw)
In-Reply-To: <20060709074543.GA4444@elte.hu>
On Sun, Jul 09, 2006 at 09:45:44AM +0200, Ingo Molnar wrote:
>
> * Andrew Morton <akpm@osdl.org> wrote:
>
> > yup, thanks, bug.
> >
> > --- a/arch/i386/kernel/time.c~get_cmos_time-locking-fix
> > +++ a/arch/i386/kernel/time.c
> > @@ -206,15 +206,16 @@ irqreturn_t timer_interrupt(int irq, voi
> > unsigned long get_cmos_time(void)
> > {
> > unsigned long retval;
> > + unsigned long flags;
> >
> > - spin_lock(&rtc_lock);
> > + spin_lock_irqsave(&rtc_lock, flags);
>
> Acked-by: Ingo Molnar <mingo@elte.hu>
>
> this bug has been in the upstream kernel for a couple of years: it was
> apparently introduced as part of HPET support, via the late_time_init()
> hook/hack in init/main.c. The lockup window is open once, during bootup.
2.6.18-rc1-mm1, which includes this change, is printing this at
the same point I used to get the lockdep message:
[ 25.628000] BUG: warning at kernel/lockdep.c:1803/trace_hardirqs_on()
[ 25.628000] [<c0104a18>] show_trace_log_lvl+0x148/0x170
[ 25.628000] [<c0105cab>] show_trace+0x1b/0x20
[ 25.628000] [<c0105cd4>] dump_stack+0x24/0x30
[ 25.628000] [<c014af4e>] trace_hardirqs_on+0xce/0x200
[ 25.628000] [<c036cf21>] _spin_unlock_irq+0x31/0x70
[ 25.628000] [<c0296584>] rtc_get_rtc_time+0x44/0x1a0
[ 25.628000] [<c01198bb>] hpet_rtc_interrupt+0x21b/0x280
[ 25.628000] [<c0161141>] handle_IRQ_event+0x31/0x70
[ 25.628000] [<c0162d37>] handle_edge_irq+0xe7/0x210
[ 25.628000] [<c0106192>] do_IRQ+0x92/0x120
[ 25.628000] [<c0104121>] common_interrupt+0x25/0x2c
[ 25.628000] [<b7f15410>] 0xb7f15410
Updated dmesg and .config:
http://home.columbus.rr.com/jfannin3/dmesg-2.6.18-rc1-mm1
http://home.columbus.rr.com/jfannin3/config-2.6.18-rc1-mm1
--
Joseph Fannin
jhf@rivenstone.net
next prev parent reply other threads:[~2006-07-11 5:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-09 5:05 Joseph Fannin
2006-07-09 6:25 ` Andrew Morton
2006-07-09 7:45 ` Ingo Molnar
2006-07-11 5:11 ` Joseph Fannin [this message]
2006-07-11 7:45 ` [patch] lockdep: HPET/RTC fix Ingo Molnar
2006-07-14 3:57 ` [PATCH] remove unnecessary barrier in rtc_get_rtc_time Steven Rostedt
2006-08-05 21:59 ` [patch] lockdep: HPET/RTC fix Joseph Fannin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060711051108.GA13574@nineveh.rivenstone.net \
--to=jfannin@gmail.com \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®