mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: [ACRYPTO] new release of asynchronous crrypto layer.
Date: Tue, 11 Jul 2006 16:01:46 +1000	[thread overview]
Message-ID: <20060711060146.GA8931@gondor.apana.org.au> (raw)
In-Reply-To: <20060711053157.GA6451@2ka.mipt.ru>

Hi Evgeniy:

On Tue, Jul 11, 2006 at 09:31:57AM +0400, Evgeniy Polyakov wrote:
>
> > I noticed a bug in the ESP IV processing.  When you do ESP asynchronously,
> > you can no longer use the last block of the previous packet as the IV of
> > the next.  This is because the next packet may have started processing
> > before the last packet has even been finalised.
> 
> I cought that bug too, so IV being used is always copied into old_iv variable,
> so integrity is stated.

My point is that it is possible for two packets to use the same IV
under this scheme, which defeats the purpose of IVs.

> > A simple solution is to generate a random IV.
> 
> Yes, it could be done too.
> But actually neither random IV, nor IV created from encrypted previous packet, 
> nor IV created from unencrypted previous packet are forbidden by spec. 
> Initial implementation used constant IV there at all.

True.  However, using the same IV more than once is definitely not a good
idea.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

      reply	other threads:[~2006-07-11  6:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-10  9:13 Evgeniy Polyakov
2006-07-11  4:55 ` Herbert Xu
2006-07-11  5:31   ` Evgeniy Polyakov
2006-07-11  6:01     ` Herbert Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060711060146.GA8931@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=johnpol@2ka.mipt.ru \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®