From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S932111AbWGLAeM@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932111AbWGLAeM (ORCPT <rfc822;willy@w.ods.org>);
	Tue, 11 Jul 2006 20:34:12 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932114AbWGLAeM
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 11 Jul 2006 20:34:12 -0400
Received: from smtp.osdl.org ([65.172.181.4]:64199 "EHLO smtp.osdl.org")
	by vger.kernel.org with ESMTP id S932111AbWGLAeM (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 11 Jul 2006 20:34:12 -0400
Date: Tue, 11 Jul 2006 17:37:35 -0700
From: Andrew Morton <akpm@osdl.org>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: pavel@ucw.cz, roubert@df.lth.se, stern@rowland.harvard.edu,
       dmitry.torokhov@gmail.com, linux-input@atrey.karlin.mff.cuni.cz,
       linux-kernel@vger.kernel.org
Subject: Re: [patch] Re: Magic Alt-SysRq change in 2.6.18-rc1
Message-Id: <20060711173735.43e9af94.akpm@osdl.org>
In-Reply-To: <Pine.LNX.4.64.0607120213060.12900@scrub.home>
References: <Pine.LNX.4.44L0.0607091657490.28904-100000@netrider.rowland.org>
	<20060710094414.GD1640@igloo.df.lth.se>
	<Pine.LNX.4.64.0607102356460.17704@scrub.home>
	<20060711124105.GA2474@elf.ucw.cz>
	<Pine.LNX.4.64.0607120016490.12900@scrub.home>
	<20060711224225.GC1732@elf.ucw.cz>
	<Pine.LNX.4.64.0607120132440.12900@scrub.home>
	<20060711165003.25265bb7.akpm@osdl.org>
	<Pine.LNX.4.64.0607120213060.12900@scrub.home>
X-Mailer: Sylpheed version 1.0.0 (GTK+ 1.2.10; i386-vine-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

Roman Zippel <zippel@linux-m68k.org> wrote:
>
> Hi,
> 
> On Tue, 11 Jul 2006, Andrew Morton wrote:
> 
> > > On Wed, 12 Jul 2006, Pavel Machek wrote:
> > > 
> > > > BTW I believe that original way (alt down, sysrq down, b down) still
> > > > works before and after the patch.
> > > 
> > > No, it doesn't.
> > > 
> > > > Here's patch that updates docs with now-working trick.
> > > 
> > > NACK.
> > > 
> > 
> > Nack your nack!  The patch in 2.6.18-rc1 makes sysrq work on machines on
> > which it *did not work at all*.  If that makes it harder to type but still
> > possible to type on other machines, well, we win.
> 
> Why can't we even _try_ to preserve compatibility? :-(
> 

It would of course be good if we could do that.  If it's impossible to
retain the old behaviour without breaking those oddball keyboards then
we're screwed.

IOW, someone needs to find a way to make the new code work like the old
code without re-breaking Pavel's keyboard.  But the bitchin-to-patchin
ratio here seems to exclude that outcome.