From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751328AbWGKVlG (ORCPT ); Tue, 11 Jul 2006 17:41:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751329AbWGKVlG (ORCPT ); Tue, 11 Jul 2006 17:41:06 -0400 Received: from wohnheim.fh-wedel.de ([213.39.233.138]:24758 "EHLO wohnheim.fh-wedel.de") by vger.kernel.org with ESMTP id S1751328AbWGKVlF (ORCPT ); Tue, 11 Jul 2006 17:41:05 -0400 Date: Tue, 11 Jul 2006 23:37:33 +0200 From: =?iso-8859-1?Q?J=F6rn?= Engel To: "Randy.Dunlap" Cc: Sam Ravnborg , hch@infradead.org, dwmw2@infradead.org, bunk@stusta.de, linux-kernel@vger.kernel.org, torvalds@osdl.org, akpm@osdl.org Subject: Re: RFC: cleaning up the in-kernel headers Message-ID: <20060711213733.GB21448@wohnheim.fh-wedel.de> References: <20060711160639.GY13938@stusta.de> <1152635323.3373.211.camel@pmac.infradead.org> <20060711173301.GA27818@infradead.org> <20060711193423.GA9685@mars.ravnborg.org> <20060711194107.GA10733@mars.ravnborg.org> <20060711134106.18f6dd2e.rdunlap@xenotime.net> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20060711134106.18f6dd2e.rdunlap@xenotime.net> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 11 July 2006 13:41:06 -0700, Randy.Dunlap wrote: > On Tue, 11 Jul 2006 21:41:07 +0200 Sam Ravnborg wrote: > > > > JÃrn Engel IIRC created a perl scrip that did this a year or two ago. > > > Try googling a bit. > > http://lkml.org/lkml/2003/10/1/74 > > That is version 2 of the script. There are also versions 3 & 4. > > http://marc.theaimsgroup.com/?l=linux-kernel&w=2&r=1&s=check+headers+for+complete+includes&q=t Boy, it took me a while to remember what I did back then. In principle, the script just compiles trivial c files with a single #include inside. Not too bad in principle, but there were two problems I couldn't solve: 1. One of the goals should be to make a compile faster, not slower. Adding further includes hardly helps. 2. It is practically impossible to test every possible combination of #ifdefs in the various headers pulled in. Problem 1 would be fairly simple, as the script could be changed slightly to prune single #include lines from headers and see if they still compile. But then there is problem 2. One possibility to tackly problem 2 would be to create a set of config files to use for automatic testing. Instead of compiling once, a header must get compiled with every config in the set. Hopefully this set would not grow too big. And in the end, there is just so much you can automate. Humans have to think about the changes before sending patches. Jörn -- Optimizations always bust things, because all optimizations are, in the long haul, a form of cheating, and cheaters eventually get caught. -- Larry Wall