From: Andrew Morton <akpm@osdl.org>
To: Martin Bligh <mbligh@google.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.6.18-rc1-git4 and 2.6.18-rc1-mm1 OOM's on boot
Date: Wed, 12 Jul 2006 18:16:36 -0700 [thread overview]
Message-ID: <20060712181636.d7cbbb99.akpm@osdl.org> (raw)
In-Reply-To: <44B528F4.6080409@google.com>
On Wed, 12 Jul 2006 09:53:08 -0700
Martin Bligh <mbligh@google.com> wrote:
> -git3 was fine
> (bootlog for git3: http://test.kernel.org/abat/40748/debug/console.log)
>
> -mm1 has the same issue
>
> Slightly different manifestations across 2 boots
>
> http://test.kernel.org/abat/40760/debug/console.log
> http://test.kernel.org/abat/40837/debug/console.log
[<c0136fcf>] out_of_memory+0x29/0xf6
[<c0137f48>] __alloc_pages+0x1ed/0x276
[<c014db73>] kmem_getpages+0x63/0xc1
[<c014e960>] cache_grow+0xaa/0x139
[<c014eb6a>] cache_alloc_refill+0x17b/0x1c0
[<c014f1ef>] __kmalloc+0x83/0x93
[<c0168cf5>] alloc_fd_array+0x19/0x24
[<c0169122>] alloc_fdtable+0xb2/0xef
[<c016917f>] expand_fdtable+0x20/0x7d
[<c0169221>] expand_files+0x45/0x50
[<c0161263>] locate_fd+0x70/0x8e
[<c01612aa>] dupfd+0x29/0x61
[<c01613dc>] sys_dup+0x1b/0x23
[<c01027d3>] syscall_call+0x7/0xb
I suspect that's because I had me a little mistake.
--- a/fs/file.c~alloc_fdtable-expansion-fix
+++ a/fs/file.c
@@ -240,7 +240,7 @@ static struct fdtable *alloc_fdtable(int
if (!fdt)
goto out;
- nfds = max_t(int, 8 * L1_CACHE_BYTES, roundup_pow_of_two(nfds));
+ nfds = max_t(int, 8 * L1_CACHE_BYTES, roundup_pow_of_two(nr + 1));
if (nfds > NR_OPEN)
nfds = NR_OPEN;
_
next prev parent reply other threads:[~2006-07-13 1:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-12 16:53 Martin Bligh
2006-07-13 1:16 ` Andrew Morton [this message]
2006-07-13 1:24 ` Martin Bligh
2006-07-13 14:12 ` Andy Whitcroft
2006-07-14 8:00 ` Andy Whitcroft
2006-07-14 8:08 ` Andrew Morton
2006-07-14 8:32 ` Andy Whitcroft
2006-07-14 10:13 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060712181636.d7cbbb99.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome