From: Andrew Morton <akpm@osdl.org>
To: Hans Reiser <reiser@namesys.com>
Cc: jeffm@suse.com, reiserfs-list@namesys.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] reiserfs: fix handling of device names with /'s in them
Date: Wed, 12 Jul 2006 21:00:27 -0700 [thread overview]
Message-ID: <20060712210027.8d7a2ddc.akpm@osdl.org> (raw)
In-Reply-To: <44B5C353.9060007@namesys.com>
On Wed, 12 Jul 2006 20:51:47 -0700
Hans Reiser <reiser@namesys.com> wrote:
> Andrew Morton wrote:
>
> >On Wed, 12 Jul 2006 12:42:28 -0400
> >Jeff Mahoney <jeffm@suse.com> wrote:
> >
> >
> >
> >> On systems with block devices containing slashes (virtual dasd, cciss,
> >> etc), reiserfs will fail to initialize /proc/fs/reiserfs/<dev> due to
> >> it being interpreted as a subdirectory. The generic block device code
> >> changes the / to ! for use in the sysfs tree. This patch uses that
> >> convention.
> >>
> >>
> >
> >Isn't it a bit dumb of us to be putting slashes in the device names anyway?
> > It would be better, if poss, to alter dasd/cciss/etc and stop all these
> >s@/@!@everywhere games.
> >
> >
> >
> >
> Isn't better to ask why there is a problem with the /'s? It would be
> bad for Linux as a design to prevent passing arbitrary tail ends of
> filenames off to arbitrary plugins of some kind. In general, in
> namespace design, you want to allow delegating the job of
> resolving/interpreting the tail end of a file that the front end has
> identified as something that can interpret it.
>
> Forgive me, I probably understand something wongly about procfs and this
> issue....
>
It's a question of being *practical*. Your observations are in the realm
of the theoretical.
Software sucks, and we get along better by not provoking it. So don't put
spaces, let alone slashes into strings which we offer to userspace.
next prev parent reply other threads:[~2006-07-13 4:00 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-12 16:42 Jeff Mahoney
2006-07-12 16:57 ` Eric Dumazet
2006-07-12 17:02 ` Jeff Mahoney
2006-07-13 0:55 ` Andrew Morton
2006-07-13 3:51 ` Hans Reiser
2006-07-13 4:00 ` Andrew Morton [this message]
2006-07-13 7:34 ` Hans Reiser
2006-07-13 5:23 ` H. Peter Anvin
[not found] <6xQ4C-6NB-43@gated-at.bofh.it>
[not found] ` <6xQea-6ZX-13@gated-at.bofh.it>
2006-07-14 16:10 ` Bodo Eggert
2006-07-14 17:50 ` Jeff Mahoney
2006-07-16 7:12 ` Hans Reiser
2006-07-16 15:56 ` Jeffrey Mahoney
2006-07-16 18:14 ` Hans Reiser
2006-07-16 22:17 ` Jeff Mahoney
2006-07-17 1:21 ` Hans Reiser
2006-07-17 1:50 ` Jeffrey Mahoney
2006-07-17 3:02 ` Hans Reiser
2006-07-17 3:17 ` Jeffrey Mahoney
2006-07-17 7:29 ` Hans Reiser
2006-07-17 14:55 ` Jeff Mahoney
2006-07-17 18:19 ` Hans Reiser
2006-07-17 18:38 ` Jeff Mahoney
2006-07-17 19:07 ` Hans Reiser
2006-07-17 19:59 ` Jeff Mahoney
2006-07-17 21:03 ` Hans Reiser
2006-07-17 22:26 ` Rudy Zijlstra
2006-07-18 0:26 ` Horst von Brand
2006-07-18 16:38 ` Jan Engelhardt
2006-07-17 18:08 ` Valdis.Kletnieks
2006-07-17 18:16 ` Jeff Mahoney
2006-07-17 18:53 ` Hans Reiser
2006-07-17 19:07 ` Jeff Mahoney
2006-07-17 18:27 ` Hans Reiser
2006-07-17 19:52 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060712210027.8d7a2ddc.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=jeffm@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=reiser@namesys.com \
--cc=reiserfs-list@namesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®