From: Andrew Morton <akpm@osdl.org>
To: Jeff Dike <jdike@addtoit.com>
Cc: linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/5] UML - Fix ZONE_HIGHMEM compilation error
Date: Thu, 13 Jul 2006 01:24:21 -0700 [thread overview]
Message-ID: <20060713012421.b59f05d4.akpm@osdl.org> (raw)
In-Reply-To: <200607121639.k6CGdiMw021221@ccure.user-mode-linux.org>
On Wed, 12 Jul 2006 12:39:43 -0400
Jeff Dike <jdike@addtoit.com> wrote:
> References to ZONE_HIGHMEM need to depend on CONFIG_HIGHMEM.
>
There are several such references in mm/page_alloc.c
>
> Index: linux-2.6.17/arch/um/kernel/mem.c
> ===================================================================
> --- linux-2.6.17.orig/arch/um/kernel/mem.c 2006-07-12 11:29:02.000000000 -0400
> +++ linux-2.6.17/arch/um/kernel/mem.c 2006-07-12 11:29:11.000000000 -0400
> @@ -226,7 +226,9 @@ void paging_init(void)
> for(i=0;i<sizeof(zones_size)/sizeof(zones_size[0]);i++)
I spy an ARRAY_SIZE().
> zones_size[i] = 0;
> zones_size[ZONE_DMA] = (end_iomem >> PAGE_SHIFT) - (uml_physmem >> PAGE_SHIFT);
> +#ifdef CONFIG_HIGHMEM
> zones_size[ZONE_HIGHMEM] = highmem >> PAGE_SHIFT;
> +#endif
> free_area_init(zones_size);
>
Maybe this is an rc1-mm1 fix? Did Christoph's patches break UML, perhaps??
next prev parent reply other threads:[~2006-07-13 8:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-12 16:39 Jeff Dike
2006-07-13 8:24 ` Andrew Morton [this message]
2006-07-13 18:17 ` Jeff Dike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060713012421.b59f05d4.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®