From: Andrew Morton <akpm@osdl.org>
To: Badari Pulavarty <pbadari@us.ibm.com>
Cc: pbadari@us.ibm.com, HOLZHEU@de.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390 hypfs fixes for 2.6.18-rc1-mm1
Date: Thu, 13 Jul 2006 02:23:04 -0700 [thread overview]
Message-ID: <20060713022304.9291852d.akpm@osdl.org> (raw)
In-Reply-To: <44B5C971.7030403@us.ibm.com>
On Wed, 12 Jul 2006 21:17:53 -0700
Badari Pulavarty <pbadari@us.ibm.com> wrote:
> +static ssize_t hypfs_aio_read(struct kiocb *iocb, const struct iovec *iov,
> + unsigned long nr_segs, loff_t offset)
> {
> char *data;
> size_t len;
> struct file *filp = iocb->ki_filp;
> + /* XXX: temporary */
> + char __user *buf = iov[0].iov_base;
> + size_t count = iov[0].iov_len;
> +
> + if (nr_segs != 1) {
> + count = -EINVAL;
> + goto out;
> + }
err, "temporary" things tend to become permanent. What's the real fix?
next prev parent reply other threads:[~2006-07-13 9:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-13 4:10 Badari Pulavarty
2006-07-13 4:17 ` Badari Pulavarty
2006-07-13 9:04 ` Cedric Le Goater
2006-07-13 16:48 ` Badari Pulavarty
2006-07-13 9:23 ` Andrew Morton [this message]
2006-07-13 14:31 ` Badari Pulavarty
2006-07-13 15:41 ` Michael Holzheu
2006-07-13 17:39 ` Badari Pulavarty
2006-07-14 10:23 ` Michael Holzheu
2006-07-13 13:44 ` Michael Holzheu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060713022304.9291852d.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=HOLZHEU@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pbadari@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome