From: Ingo Molnar <mingo@elte.hu>
To: john stultz <johnstul@us.ibm.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
Roman Zippel <zippel@linux-m68k.org>,
Thomas Gleixner <tglx@linutronix.de>,
mikpe@it.uu.se
Subject: Re: [RFC][PATCH] Kill i386 references to xtime
Date: Thu, 13 Jul 2006 11:12:18 +0200 [thread overview]
Message-ID: <20060713091218.GB7480@elte.hu> (raw)
In-Reply-To: <1152750597.11963.43.camel@localhost.localdomain>
* john stultz <johnstul@us.ibm.com> wrote:
> All,
> Just another cleanup patch from the C3 timekeeping tree (which you can
> find here: http://sr71.net/~jstultz/tod/ ) I wanted to RFC.
>
> This patch kills all xtime references in i386 and replaces them with
> proper settimeofday()/gettimeofday() calls.
>
> I'm not sure the APM changes are 100% right, as that code is very
> muddled (take the i8253_lock before calling reinit_timer, which would
> take the i8253_lock again and hang if it weren't ifdef'ed out!).
yeah, that code looks very suspect.
> Anyway, testing, feedback or comments would be appreciated!
These cleanups look good to me. I gave your patch a testrun on a
lockdep-enabled allyesconfig bzImage kernel on i686, and there are no
apprent problems - it booted up just fine.
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
next prev parent reply other threads:[~2006-07-13 9:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-13 0:18 [RFC] Move NTP related code to ntp.c john stultz
2006-07-13 0:29 ` [RFC][PATCH] Kill i386 references to xtime john stultz
2006-07-13 9:12 ` Ingo Molnar [this message]
2006-07-13 9:04 ` [RFC] Move NTP related code to ntp.c Ingo Molnar
2006-07-13 11:43 ` Roman Zippel
2006-07-13 12:19 [RFC][PATCH] Kill i386 references to xtime Mikael Pettersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060713091218.GB7480@elte.hu \
--to=mingo@elte.hu \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@it.uu.se \
--cc=tglx@linutronix.de \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®