From: Sam Ravnborg <sam@ravnborg.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Roman Zippel <zippel@linux-m68k.org>,
wookey@debian.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Support DOS line endings
Date: Thu, 13 Jul 2006 23:07:25 +0200 [thread overview]
Message-ID: <20060713210725.GA1923@mars.ravnborg.org> (raw)
In-Reply-To: <20060713200223.GL1629@parisc-linux.org>
On Thu, Jul 13, 2006 at 02:02:23PM -0600, Matthew Wilcox wrote:
> On Thu, Jul 13, 2006 at 09:35:43PM +0200, Sam Ravnborg wrote:
> > --- a/scripts/kconfig/confdata.c
> > +++ b/scripts/kconfig/confdata.c
> > @@ -195,6 +195,8 @@ load:
> > p2 = strchr(p, '\n');
> > if (p2)
> > *p2 = 0;
> > + if (*--p2 == '\r')
> > + *p2 = 0;
>
> ... but if p2 is NULL ...
>
> so:
> if (p2) {
> *p2 = 0;
> if (*--p2 == '\r')
> *p2 = 0;
> }
>
> but maybe it'd be better to do ...
>
> if (p2) {
> *p2-- = 0;
> if (*p2 == '\r')
> *p2 = 0;
> }
Thanks. Maybe I should just stop trying to code anything today ;-)
Sam
next prev parent reply other threads:[~2006-07-13 21:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-07 17:34 Matthew Wilcox
2006-07-07 22:35 ` Sam Ravnborg
2006-07-08 3:23 ` Roman Zippel
2006-07-13 18:18 ` Sam Ravnborg
2006-07-13 18:29 ` Matthew Wilcox
2006-07-13 18:47 ` Roman Zippel
2006-07-13 19:35 ` Sam Ravnborg
2006-07-13 20:02 ` Matthew Wilcox
2006-07-13 21:07 ` Sam Ravnborg [this message]
2006-07-13 21:41 ` Bernd Petrovitsch
2006-07-19 12:02 ` Alistair John Strachan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060713210725.GA1923@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=wookey@debian.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®