From: Masayuki Saito <m-saito@tnes.nec.co.jp>
To: Nathan Scott <nathans@sgi.com>
Cc: David Chinner <dgc@sgi.com>,
xfs@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: i_state of inode is changed after the inode is freed
Date: Fri, 14 Jul 2006 19:25:20 +0900 [thread overview]
Message-ID: <20060714192520m-saito@mail.aom.tnes.nec.co.jp> (raw)
In-Reply-To: <20060710103740.B1674239@wobbly.melbourne.sgi.com>
Hi, Nathan.
>I'll leave it to Dave to comment more later (he's travelling at the
>moment), since he's had his head deep in this area of the code most
>recently - but my first thoughts on your patch are that its solving
>the problem incorrectly. We should not be in the destroy_inode code
>if the inode reference counting is correct everywhere - I would have
>expected the fix to be a get/put style change, rather than adding an
>inode lock and new lock/unlock semantics around an individual field;
>... and if that cannot be done to fix this (eh?), then some comments
>as to why refcounting didn't solve the problem here.
On the basis of the above, I consider the get/put style fix which use
i_count.
This problem is that i_state of the inode is changed while the inode
is freed in xfs filesystem. And the cause is that the inode release
and xfs_iunpun() can run in parallel.
To fix this problem, I added a pair of igrab()/iput() before and behind
mark_inode_dirty_sync() at xfs_iunpin(). I think this can change it as
follows.
(1)The case that the inode release transaction runs after xfs_iunpin()
is called.
While mark_inode_dirty_sync() is running, igrab() promises that the
inode is alive.
(2)The case that xfs_iunpin() is called after iput() in the inode
release transaction is called(i_count is 0).
mark_inode_dirty_sync() is not called because the igrab() can not get
the inode.
I have made the following patch, but it is not yet tested.
I would like to hear your comment, first.
Signed-off-by: Masayuki Saito <m-saito@tnes.nec.co.jp>
---
--- linux-2.6.17.4/fs/xfs/xfs_inode.c.orig 2006-07-14 09:44:44.187844139 +0900
+++ linux-2.6.17.4/fs/xfs/xfs_inode.c 2006-07-14 09:58:26.398486290 +0900
@@ -2751,8 +2751,14 @@ xfs_iunpin(
if (vp) {
struct inode *inode = vn_to_inode(vp);
- if (!(inode->i_state & I_NEW))
- mark_inode_dirty_sync(inode);
+ if (!(inode->i_state &
+ (I_NEW|I_FREEING|I_CLEAR))) {
+ inode = igrab(inode);
+ if (inode != NULL) {
+ mark_inode_dirty_sync(inode);
+ iput(inode);
+ }
+ }
}
}
wake_up(&ip->i_ipin_wait);
next prev parent reply other threads:[~2006-07-14 10:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-04 12:52 Masayuki Saito
2006-07-04 20:41 ` David Chinner
2006-07-07 12:41 ` Masayuki Saito
2006-07-10 0:37 ` Nathan Scott
2006-07-14 10:25 ` Masayuki Saito [this message]
2006-07-17 11:05 ` Nathan Scott
2006-07-17 14:07 ` David Chinner
2006-07-24 8:01 ` Masayuki Saito
2006-08-14 2:59 ` David Chinner
2006-08-22 7:48 ` Masayuki Saito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060714192520m-saito@mail.aom.tnes.nec.co.jp \
--to=m-saito@tnes.nec.co.jp \
--cc=dgc@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nathans@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®