mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alasdair G Kergon <agk@redhat.com>
To: Peter Osterlund <petero2@telia.com>
Cc: linux-kernel@vger.kernel.org,
	Arjan van de Ven <arjan@linux.intel.com>,
	dm-devel@redhat.com, Ingo Molnar <mingo@elte.hu>,
	Milan Broz <mbroz@redhat.com>,
	"Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>
Subject: Re: lockdep warning when nesting dm devices
Date: Mon, 17 Jul 2006 03:45:19 +0100	[thread overview]
Message-ID: <20060717024519.GA26318@agk.surrey.redhat.com> (raw)
In-Reply-To: <m34pxj6rsm.fsf@telia.com>

On Sat, Jul 15, 2006 at 01:17:29PM +0200, Peter Osterlund wrote:
> # echo "0 10000 linear /dev/loop0 0" | /sbin/dmsetup create test
> # echo "0 10000 linear /dev/mapper/test 0" | /sbin/dmsetup create test2
 
> I get the following warning from the lockdep validator.
> =============================================
> [ INFO: possible recursive locking detected ]
> ---------------------------------------------

Well at first sight the message is simply pointing out something expected - it
only say "INFO" after all - viz. recursive use of
	down_read(&md->io_lock);
something tied up with the split_bio horridness which needs to go away some
day.  The lock prevents any attempt to suspend the device from happening
while a bio is in the process of being split into other bios.

Of course it's always helpful to review code from different perspectives
like this to look out for any gotchas and we ought to re-check the use
of this lock.

> Btw, is there a limit on how many dm devices can be chained? I guess
> there will be a kernel stack overflow if you try to chain together too
> many devices.

There's a patch in -mm which tackles that, but it needs some changes to dm
(which Milan Broz has begun working on) before it will behave correctly in all
cases.
 
Alasdair
-- 
agk@redhat.com

  reply	other threads:[~2006-07-17  2:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-15 11:17 Peter Osterlund
2006-07-17  2:45 ` Alasdair G Kergon [this message]
2006-07-17  9:16   ` Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060717024519.GA26318@agk.surrey.redhat.com \
    --to=agk@redhat.com \
    --cc=arjan@linux.intel.com \
    --cc=dm-devel@redhat.com \
    --cc=j-nomura@ce.jp.nec.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mbroz@redhat.com \
    --cc=mingo@elte.hu \
    --cc=petero2@telia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®