mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Prakash Punnoor <prakash@punnoor.de>
To: Andreas Mohr <andi@rhlx01.fht-esslingen.de>
Cc: linux-kernel@vger.kernel.org, keir@xensource.com,
	Tony Lindgren <tony@atomide.com>,
	zach@vmware.com, Ingo Molnar <mingo@elte.hu>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: kernel/timer.c: next_timer_interrupt() strange/buggy(?) code (2.6.18-rc1-mm2)
Date: Tue, 18 Jul 2006 17:14:06 +0200	[thread overview]
Message-ID: <200607181714.10386.prakash@punnoor.de> (raw)
In-Reply-To: <20060717185330.GA32264@rhlx01.fht-esslingen.de>

[-- Attachment #1: Type: text/plain, Size: 1537 bytes --]

Am Montag Juli 17 2006 20:53 schrieb Andreas Mohr:
>         for (i = 0; i < 4; i++) {
>                 j = INDEX(i);
>                 do {
>                         if (list_empty(varray[i]->vec + j)) {
>                                 j = (j + 1) & TVN_MASK;
>                                 continue;
>                         }
>                         list_for_each_entry(nte, varray[i]->vec + j, entry)
>                                 if (time_before(nte->expires, expires))
>                                         expires = nte->expires;
>                         if (j < (INDEX(i)) && i < 3)
>                                 list = varray[i + 1]->vec + (INDEX(i + 1));
>                         goto found;
>                 } while (j != (INDEX(i)));
>         }
> found:

is equivalent to

  for (i = 0; i < 4; i++) {
      j = INDEX(i);
      do {
          if (!list_empty(varray[i]->vec + j)) {
              list_for_each_entry(nte, varray[i]->vec + j, entry)
                  if (time_before(nte->expires, expires))
                      expires = nte->expires;
              if (j < (INDEX(i)) && i < 3)
                  list = varray[i + 1]->vec + (INDEX(i + 1));
              goto found;
          }
          j = (j + 1) & TVN_MASK;
      } while (j != (INDEX(i)));
  }
  found:


But probably the code in timer.c takes account of probabilities, thus it is a 
bit more obscure.

HTH,
-- 
(°=                 =°)
//\ Prakash Punnoor /\\
V_/                 \_V

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

  parent reply	other threads:[~2006-07-18 15:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-17 18:53 Andreas Mohr
2006-07-17 19:01 ` Michael Buesch
2006-07-17 19:57 ` Valdis.Kletnieks
2006-07-18  1:50   ` Steven Rostedt
2006-07-18 14:29   ` Michael Buesch
2006-07-18 14:50     ` Valdis.Kletnieks
2006-07-18 15:04       ` Michael Buesch
2006-07-17 20:22 ` Andreas Schwab
2006-07-18  1:47 ` [PATCH] fix bad macro param in timer.c (was: kernel/timer.c: next_timer_interrupt() strange/buggy(?) code (2.6.18-rc1-mm2)) Steven Rostedt
2006-07-18  1:59   ` [PATCH] fix bad macro param in timer.c Steven Rostedt
2006-07-18 15:14 ` Prakash Punnoor [this message]
2006-07-18 16:02   ` offtopic boot parameter notsc [Was: Re: kernel/timer.c: next_timer_interrupt() strange/buggy(?) code (2.6.18-rc1-mm2)] Sergio Monteiro Basto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200607181714.10386.prakash@punnoor.de \
    --to=prakash@punnoor.de \
    --cc=andi@rhlx01.fht-esslingen.de \
    --cc=keir@xensource.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=tony@atomide.com \
    --cc=zach@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®