mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: cramerj@intel.com, john.ronciak@intel.com,
	jesse.brandeburg@intel.com, jeffrey.t.kirsher@intel.com,
	auke-jan.h.kok@intel.com,
	kernel list <linux-kernel@vger.kernel.org>
Subject: e1000: "fix" it on thinkpad x60
Date: Fri, 21 Jul 2006 02:58:32 +0200	[thread overview]
Message-ID: <20060721005832.GA1889@elf.ucw.cz> (raw)

e1000 in thinkpad x60 fails without this dirty hack. What to do with
it?

Signed-off-by: Pavel Machek <pavel@suse.cz>

---
commit 6414eba4f65ded35f3a8f2d61261d1134e292506
tree e6560bba2cc0d18b76075e6b5db415d6c0c31db3
parent fa6f216422f9020c06dd1137aec8c72224cbe440
author <pavel@amd.ucw.cz> Fri, 21 Jul 2006 02:16:52 +0200
committer <pavel@amd.ucw.cz> Fri, 21 Jul 2006 02:16:52 +0200

 drivers/net/e1000/e1000_main.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
index 6e7d31b..808c442 100644
--- a/drivers/net/e1000/e1000_main.c
+++ b/drivers/net/e1000/e1000_main.c
@@ -842,8 +842,10 @@ e1000_probe(struct pci_dev *pdev,
 
 	if (e1000_validate_eeprom_checksum(&adapter->hw) < 0) {
 		DPRINTK(PROBE, ERR, "The EEPROM Checksum Is Not Valid\n");
+/*
 		err = -EIO;
 		goto err_eeprom;
+*/
 	}
 
 	/* copy the MAC address out of the EEPROM */

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

             reply	other threads:[~2006-07-20 15:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-21  0:58 Pavel Machek [this message]
2006-07-20 16:21 ` e1000: "fix" it on thinkpad x60 / eeprom checksum read fails Auke Kok
2006-07-20 17:07   ` Pavel Machek
2006-07-20 17:34     ` Auke Kok
2006-07-21 13:41       ` Andrew Morton
2006-07-21 15:12         ` Theodore Tso
2006-07-21 15:22           ` Auke Kok
2006-07-22  0:21             ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060721005832.GA1889@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=auke-jan.h.kok@intel.com \
    --cc=cramerj@intel.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=john.ronciak@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome