From: Andrew Morton <akpm@osdl.org>
To: Jeremy Higdon <jeremy@sgi.com>
Cc: jpk@sgi.com, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/1] - sgiioc4: fixup use of mmio ops
Date: Fri, 21 Jul 2006 06:16:42 -0700 [thread overview]
Message-ID: <20060721061642.923c7052.akpm@osdl.org> (raw)
In-Reply-To: <20060720051929.GB763333@sgi.com>
On Wed, 19 Jul 2006 22:19:29 -0700
Jeremy Higdon <jeremy@sgi.com> wrote:
> On Wed, Jul 19, 2006 at 10:31:55AM -0500, John Keller wrote:
> > Resend #2 changes include:
> >
> > - use 'void __iomem *' for ioremap() return values,
> > and handle error cases.
> >
> > sgiioc4.c had been recently converted to using mmio ops.
> > There are still a few issues to cleanup.
> >
> > Signed-off-by: jpk@sgi.com
> Signed-off-by: jeremy@sgi.com
hrm. I think we're owed a couple of iounmap()s, please. One in the
ide_dma_sgiioc4() error path and one in the takedown path.
Maybe that was one of the "few issues to cleanup", but it's a pretty simple
one.
next prev parent reply other threads:[~2006-07-21 13:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-19 15:31 John Keller
2006-07-20 5:19 ` Jeremy Higdon
2006-07-21 13:16 ` Andrew Morton [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-07-24 13:56 John Keller
2006-07-12 17:57 John Keller
2006-07-12 19:52 ` Jeremy Higdon
2006-07-12 20:36 ` Jeff Garzik
2006-07-13 13:54 ` John Keller
2006-07-13 14:45 ` Jeff Garzik
2006-07-12 23:11 ` Brent Casavant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060721061642.923c7052.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=jeremy@sgi.com \
--cc=jpk@sgi.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®