From: Andrew Morton <akpm@osdl.org>
To: Pekka J Enberg <penberg@cs.Helsinki.FI>
Cc: alan@lxorguk.ukuu.org.uk, tytso@mit.edu,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [RFC/PATCH] revoke/frevoke system calls
Date: Fri, 21 Jul 2006 17:19:22 -0700 [thread overview]
Message-ID: <20060721171922.602706f9.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0607201504040.18901@sbz-30.cs.Helsinki.FI>
On Thu, 20 Jul 2006 15:07:30 +0300 (EEST)
Pekka J Enberg <penberg@cs.Helsinki.FI> wrote:
> From: Pekka Enberg <penberg@cs.helsinki.fi>
>
> This patch implements the revoke(2) and frevoke(2) system calls for all
> types of files.
>
> ...
>
> - file = fget_light(fd, &fput_needed);
> + file = fget(fd);
This is sad.
> +static int revoke_files(struct task_struct *owner, struct inode *inode,
> + struct file *exclude, struct list_head *to_close)
> +{
> ...
> + spin_lock(&files->file_lock);
> ...
> + revoked = kmalloc(sizeof(*revoked), GFP_KERNEL);
This is bad.
next prev parent reply other threads:[~2006-07-22 0:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-20 12:07 Pekka J Enberg
2006-07-20 20:02 ` Kari Hurtta
2006-07-20 21:09 ` Björn Steinbrink
2006-07-21 22:16 ` Edgar Toernig
2006-07-22 0:19 ` Andrew Morton [this message]
2006-07-22 6:22 ` Pekka J Enberg
2006-07-22 6:59 ` Andrew Morton
2006-07-22 7:41 ` Pekka Enberg
[not found] <6AFvY-7ZK-15@gated-at.bofh.it>
2006-07-20 21:26 ` Bodo Eggert
2006-07-20 23:01 ` roucaries bastien
2006-07-22 8:05 Albert Cahalan
2006-08-07 10:45 ` Pekka Enberg
2006-08-07 15:19 ` Albert Cahalan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060721171922.602706f9.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.Helsinki.FI \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome