mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tom Rini <trini@kernel.crashing.org>
To: Peter Korsgaard <jacmet@sunsite.dk>, Andrew Morton <akpm@osdl.org>
Cc: rpurdie@rpsys.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix ppc32 zImage inflate
Date: Sat, 22 Jul 2006 10:27:34 -0700	[thread overview]
Message-ID: <20060722172734.GK24522@smtp.west.cox.net> (raw)
In-Reply-To: <87lkqoj564.fsf@slug.be.48ers.dk>

On Thu, Jul 20, 2006 at 06:01:23AM +0200, Peter Korsgaard wrote:
> >>>>> "Peter" == Peter Korsgaard <jacmet@sunsite.dk> writes:
> 
>  Peter> Hi,
>  Peter> The recent zlib update (commit
>  Peter> 4f3865fb57a04db7cca068fed1c15badc064a302) broke ppc32 zImage
>  Peter> decompression as it tries to decompress to address zero and the
>  Peter> updated zlib_inflate checks that strm->next_out isn't a null pointer.
> 
>  Peter> This little patch fixes it.
> 
> Crap - forgot to sign off :/
> 

Acked-by: Tom Rini <trini@kernel.crashing.org>

> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
> 
> diff -Naur linux-2.6.18-rc2.orig/lib/zlib_inflate/inflate.c linux-2.6.18-rc2/lib/zlib_inflate/inflate.c
> --- linux-2.6.18-rc2.orig/lib/zlib_inflate/inflate.c	2006-07-20 10:26:21.000000000 +0200
> +++ linux-2.6.18-rc2/lib/zlib_inflate/inflate.c	2006-07-20 17:02:27.000000000 +0200
> @@ -347,7 +347,7 @@
>      static const unsigned short order[19] = /* permutation of code lengths */
>          {16, 17, 18, 0, 8, 7, 9, 6, 10, 5, 11, 4, 12, 3, 13, 2, 14, 1, 15};
>  
> -    if (strm == NULL || strm->state == NULL || strm->next_out == NULL ||
> +    if (strm == NULL || strm->state == NULL ||
>          (strm->next_in == NULL && strm->avail_in != 0))
>          return Z_STREAM_ERROR;
> 
> -- 
> Bye, Peter Korsgaard
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
Tom Rini

      reply	other threads:[~2006-07-22 17:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-20  3:56 Peter Korsgaard
2006-07-20  4:01 ` Peter Korsgaard
2006-07-22 17:27   ` Tom Rini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060722172734.GK24522@smtp.west.cox.net \
    --to=trini@kernel.crashing.org \
    --cc=akpm@osdl.org \
    --cc=jacmet@sunsite.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®