From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751251AbWGZKyY (ORCPT ); Wed, 26 Jul 2006 06:54:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751281AbWGZKyY (ORCPT ); Wed, 26 Jul 2006 06:54:24 -0400 Received: from mtagate4.de.ibm.com ([195.212.29.153]:5488 "EHLO mtagate4.de.ibm.com") by vger.kernel.org with ESMTP id S1751251AbWGZKyX (ORCPT ); Wed, 26 Jul 2006 06:54:23 -0400 Date: Wed, 26 Jul 2006 12:52:04 +0200 From: Heiko Carstens To: Pekka J Enberg Cc: Christoph Lameter , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Martin Schwidefsky , manfred@colorfullife.com Subject: Re: [patch 2/2] slab: always consider arch mandated alignment Message-ID: <20060726105204.GF9592@osiris.boeblingen.de.ibm.com> References: <20060722162607.GA10550@osiris.ibm.com> <20060723073500.GA10556@osiris.ibm.com> <20060723162427.GA10553@osiris.ibm.com> <20060726085113.GD9592@osiris.boeblingen.de.ibm.com> <20060726101340.GE9592@osiris.boeblingen.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: mutt-ng/devel-r804 (Linux) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 26, 2006 at 01:37:42PM +0300, Pekka J Enberg wrote: > On Wed, 26 Jul 2006, Heiko Carstens wrote: > > It's enough to fix the ARCH_SLAB_MINALIGN problem. But it does _not_ fix the > > ARCH_KMALLOC_MINALIGN problem. s390 currently only uses ARCH_KMALLOC_MINALIGN > > since that should be good enough and it doesn't disable as much debugging > > as ARCH_SLAB_MINALIGN does. > > What exactly isn't clear from the description of the first patch? Or why do > > you consider it bogus? > > Now I am confused. What do you mean by "doesn't disable as much debugging > as ARCH_SLAB_MINALIGN does"? AFAICT, the SLAB_RED_ZONE and SLAB_STORE_USER > options _require_ BYTES_PER_WORD alignment, so if s390 requires 8 > byte alignment, you can't have them debugging anyhow... We only specify ARCH_KMALLOC_MINALIGN, since that aligns only the kmalloc caches, but it doesn't disable debugging on other caches that are created via kmem_cache_create() where an alignment of e.g. 0 is specified. The point of the first patch is: why should the slab cache be allowed to chose an aligment that is less than what the caller specified? This does very likely break things.