From: Andrew Morton <akpm@osdl.org>
To: Anton Altaparmakov <aia21@cam.ac.uk>
Cc: nickpiggin@yahoo.com.au, eike-kernel@sf-tec.de,
linux-kernel@vger.kernel.org, aia21@cantab.net
Subject: Re: [BUG?] possible recursive locking detected
Date: Thu, 27 Jul 2006 00:38:06 -0700 [thread overview]
Message-ID: <20060727003806.def43f26.akpm@osdl.org> (raw)
In-Reply-To: <1153984527.21849.2.camel@imp.csi.cam.ac.uk>
On Thu, 27 Jul 2006 08:15:27 +0100
Anton Altaparmakov <aia21@cam.ac.uk> wrote:
> > I'm surprised ext2 is allocating with __GFP_FS set, though. Would that
> > cause any problem?
>
> That is an ext2 bug IMO.
There is no bug.
What there is is an ill-defined set of rules. If we want to tighten these
rules we have a choice between
a) Never enter page reclaim while holding i_mutex or
b) never take i_mutex on the page reclaim path.
Implementing a) would be a disaster. It means that our main write()
implementation in mm/filemap.c (which holds i_mutex) wouldn't be able to
reclaim pages to satisfy the write. And generally, we do want to use the
strongest memory allocation mode at all times.
So we'll have a better kernel if we implement b).
next prev parent reply other threads:[~2006-07-27 7:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-26 16:05 Rolf Eike Beer
2006-07-27 5:53 ` Andrew Morton
2006-07-27 6:51 ` Nick Piggin
2006-07-27 7:15 ` Anton Altaparmakov
2006-07-27 7:38 ` Andrew Morton [this message]
2006-07-27 8:19 ` Anton Altaparmakov
2006-07-27 8:53 ` Andrew Morton
2006-07-27 9:28 ` Anton Altaparmakov
2006-07-27 9:46 ` Ingo Molnar
2006-07-27 14:31 ` Anton Altaparmakov
2006-07-27 14:45 ` Ingo Molnar
2006-07-27 18:04 ` Andrew Morton
2006-07-27 9:18 ` Nick Piggin
2006-07-27 9:35 ` Anton Altaparmakov
2006-07-27 10:02 ` Nick Piggin
2006-07-27 12:30 ` Anton Altaparmakov
2006-07-27 7:24 ` Andrew Morton
2006-07-27 7:29 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060727003806.def43f26.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=aia21@cam.ac.uk \
--cc=aia21@cantab.net \
--cc=eike-kernel@sf-tec.de \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®