From: Arnd Bergmann <arnd.bergmann@de.ibm.com>
To: Josef Sipek <jsipek@fsl.cs.sunysb.edu>
Cc: liyu <liyu@ccoss.com.cn>, LKML <linux-kernel@vger.kernel.org>,
Greg KH <greg@kroah.com>, Peter <peter@maubp.freeserve.co.uk>,
The Doctor <thedoctor@tardis.homelinux.org>
Subject: Re: [PATCH 2/2] usbhid: HID device simple driver interface
Date: Thu, 27 Jul 2006 01:54:12 +0200 [thread overview]
Message-ID: <200607270154.14021.arnd.bergmann@de.ibm.com> (raw)
In-Reply-To: <20060726161055.GB28284@filer.fsl.cs.sunysb.edu>
On Wednesday 26 July 2006 18:10, Josef Sipek wrote:
> You should use (hid) instead of hid. Because of how the pre-processor works.
>
Or, even better, use an inline function instead of a macro whereever
possible.
One more thing, the description for patch 1 can probably be refined
a bit more and put into Documentation/somewhere as a new file.
Regarding the split of the patch, it's usually a bad idea to
put the header file into a separate patch from its users.
E.g. if someone during debugging tries to revert patch 2 but not
patch 1, he ends up with a broken build.
Arnd <><
next prev parent reply other threads:[~2006-07-26 23:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-26 10:41 liyu
2006-07-26 16:10 ` Josef Sipek
2006-07-26 23:54 ` Arnd Bergmann [this message]
2006-07-27 1:17 ` liyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200607270154.14021.arnd.bergmann@de.ibm.com \
--to=arnd.bergmann@de.ibm.com \
--cc=greg@kroah.com \
--cc=jsipek@fsl.cs.sunysb.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=liyu@ccoss.com.cn \
--cc=peter@maubp.freeserve.co.uk \
--cc=thedoctor@tardis.homelinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome