From: Christoph Hellwig <hch@infradead.org>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Linus Torvalds <torvalds@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Eugene Teo <eteo@redhat.com>
Subject: Re: Require mmap handler for a.out executables
Date: Thu, 27 Jul 2006 16:07:37 +0100 [thread overview]
Message-ID: <20060727150737.GA29521@infradead.org> (raw)
In-Reply-To: <1153909881.746.39.camel@localhost>
> diff --git a/fs/binfmt_aout.c b/fs/binfmt_aout.c
> index f312103..5638acf 100644
> --- a/fs/binfmt_aout.c
> +++ b/fs/binfmt_aout.c
> @@ -278,6 +278,9 @@ static int load_aout_binary(struct linux
> return -ENOEXEC;
> }
>
> + if (!bprm->file->f_op || !bprm->file->f_op->mmap)
> + return -ENOEXEC;
> +
These checks need a big comment explanining why they are there, else people
will remove them again by accident.
next prev parent reply other threads:[~2006-07-27 15:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-26 10:31 Marcel Holtmann
2006-07-27 15:07 ` Christoph Hellwig [this message]
2006-07-27 15:18 ` Linus Torvalds
2006-07-27 15:44 ` Marcel Holtmann
2006-07-27 17:21 ` Eugene Teo
[not found] <6COYh-8f0-41@gated-at.bofh.it>
2006-07-27 17:49 ` Bodo Eggert
2006-07-27 17:59 ` Eugene Teo
2006-07-27 18:25 ` Alan Cox
2006-07-27 21:18 ` Bodo Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060727150737.GA29521@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=eteo@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome