mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nathan Scott <nathans@sgi.com>
To: Josh Triplett <josht@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
	xfs@oss.sgi.com
Subject: Re: [PATCH] [xfs] Add lock annotations to xfs_trans_update_ail and xfs_trans_delete_ail
Date: Fri, 28 Jul 2006 09:20:36 +1000	[thread overview]
Message-ID: <20060728092035.C2196410@wobbly.melbourne.sgi.com> (raw)
In-Reply-To: <1153938323.12517.58.camel@josh-work.beaverton.ibm.com>; from josht@us.ibm.com on Wed, Jul 26, 2006 at 11:25:23AM -0700

On Wed, Jul 26, 2006 at 11:25:23AM -0700, Josh Triplett wrote:
> xfs_trans_update_ail and xfs_trans_delete_ail get called with the AIL lock
> held, and release it.  Add lock annotations to these two functions (abstracted
> like the AIL lock itself) so that sparse can check callers for lock pairing,
> and so that sparse will not complain about these functions since they
> intentionally use locks in this manner.

Thanks Josh, looks good - I'll get it merged.  I'd prefer to just
open code the use of __acquires/__releases for clarity, but I can
easily make that change before merging.

cheers.

-- 
Nathan

      reply	other threads:[~2006-07-27 23:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-26 18:25 Josh Triplett
2006-07-27 23:20 ` Nathan Scott [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060728092035.C2196410@wobbly.melbourne.sgi.com \
    --to=nathans@sgi.com \
    --cc=akpm@osdl.org \
    --cc=josht@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®