Re: [PATCH] 2.6.18-rc2-mm1: unresolved symbol brnf_deferred_hooks in xt_physdev module

[Andrew Morton <akpm@osdl.org>]

On Fri, 28 Jul 2006 13:38:21 +0200
Bernhard Rosenkraenzer <bero@arklinux.org> wrote:

> The (trivial) patch below fixes the unresolved symbol brnf_deferred_hooks in 
> the xt_physdev module in 2.6.18-rc2-mm1.
> 
> Signed-off-by: Bernhard Rosenkraenzer <bero@arklinux.org>
> 
> ---
> --- linux-2.6.17/net/netfilter/xt_physdev.c.ark	2006-07-28 13:34:31.000000000 
> +0200
> +++ linux-2.6.17/net/netfilter/xt_physdev.c	2006-07-28 13:34:48.000000000 
> +0200
> @@ -16,6 +16,8 @@
>  #define MATCH   1
>  #define NOMATCH 0
>  
> +extern int brnf_deferred_hooks;
> +
>  MODULE_LICENSE("GPL");
>  MODULE_AUTHOR("Bart De Schuymer <bdschuym@pandora.be>");
>  MODULE_DESCRIPTION("iptables bridge physical device match module");

OK, but please never put extern declarations in .c files.  They need to go
in a header where the compiler can check that the variable's type is
consistent at all usage sites.

We already have such a declaration, so I guess this is the fix:

--- a/net/netfilter/xt_physdev.c~xt_physdev-build-fix
+++ a/net/netfilter/xt_physdev.c
@@ -10,6 +10,7 @@
 
 #include <linux/module.h>
 #include <linux/skbuff.h>
+#include <linux/netfilter/netfilter_bridge.h>
 #include <linux/netfilter/xt_physdev.h>
 #include <linux/netfilter/x_tables.h>
 #include <linux/netfilter_bridge.h>
_


Your email client is wordwrapping patches, btw.  There's a lot of it going
round at present.