From: Chuck Ebbert <76306.1226@compuserve.com>
To: Andi Kleen <ak@suse.de>
Cc: Albert Cahalan <acahalan@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: [patch] x86_64: fix is_at_popf() for compat tasks
Date: Mon, 31 Jul 2006 03:22:42 -0400 [thread overview]
Message-ID: <200607310325_MC3-1-C691-D76B@compuserve.com> (raw)
When testing for the REX instruction prefix, first check
for a 32-bit task because in compat mode the REX prefix is an
increment instruction.
Signed-off-by: Chuck Ebbert <76306.1226@compuserve.com>
---
Compiled and booted but needs a test case...
--- 2.6.18-rc2-64.orig/arch/x86_64/kernel/ptrace.c
+++ 2.6.18-rc2-64/arch/x86_64/kernel/ptrace.c
@@ -141,8 +141,11 @@ static int is_at_popf(struct task_struct
case 0xf0: case 0xf2: case 0xf3:
continue;
- /* REX prefixes */
case 0x40 ... 0x4f:
+ if (is_compat_task())
+ /* register increment */
+ return 0;
+ /* REX prefix */
continue;
/* CHECKME: f0, f2, f3 */
--
Chuck
next reply other threads:[~2006-07-31 7:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-31 7:22 Chuck Ebbert [this message]
2006-07-31 8:54 ` Andi Kleen
2006-07-31 16:59 Chuck Ebbert
2006-07-31 20:06 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200607310325_MC3-1-C691-D76B@compuserve.com \
--to=76306.1226@compuserve.com \
--cc=acahalan@gmail.com \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®