From: Yasunori Goto <y-goto@jp.fujitsu.com>
To: kmannth@us.ibm.com
Cc: lkml <linux-kernel@vger.kernel.org>, andrew <akpm@osdl.org>,
discuss <discuss@x86-64.org>, dave hansen <haveblue@us.ibm.com>,
Andi Kleen <ak@suse.de>, konrad <darnok@us.ibm.com>,
lhms-devel <lhms-devel@lists.sourceforge.net>,
kame <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [Lhms-devel] [Patch] 3/5 in support of hot-add memory x86_64 arch_find_node x86_64
Date: Mon, 31 Jul 2006 17:30:55 +0900 [thread overview]
Message-ID: <20060731171336.B86E.Y-GOTO@jp.fujitsu.com> (raw)
In-Reply-To: <1154141562.5874.147.camel@keithlap>
> diff -urN orig/arch/x86_64/mm/srat.c work/arch/x86_64/mm/srat.c
> --- orig/arch/x86_64/mm/srat.c 2006-07-28 13:57:35.000000000 -0400
> +++ work/arch/x86_64/mm/srat.c 2006-07-28 21:19:01.000000000 -0400
> @@ -450,3 +450,15 @@
> }
>
> EXPORT_SYMBOL(__node_distance);
> +
> +int arch_find_node(unsigned long start, unsigned long size)
> +{
> + int i, ret = 0;
> + unsigned long end = start+size;
> +
> + for_each_node(i) {
> + if (nodes_add[i].start <= start && nodes_add[i].end >= end)
> + ret = i;
> + }
> + return ret;
> +}
BTW, does anyone know why nodes_add[] becomes arch dependent code?
I know it is defined in x86-64. But I mean that SRAT is not
arch dependent. It is defined by just ACPI.
However, each arch which uses ACPI has a own code to parse SRAT table.
Is it hard to merge all of them? Are there any special case?
If they can be merged, this code can be written in driver/acpi/numa.c.
Bye.
--
Yasunori Goto
next prev parent reply other threads:[~2006-07-31 8:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-29 2:52 keith mannthey
2006-07-31 8:30 ` Yasunori Goto [this message]
2006-07-31 8:57 ` [Lhms-devel] " Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060731171336.B86E.Y-GOTO@jp.fujitsu.com \
--to=y-goto@jp.fujitsu.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=darnok@us.ibm.com \
--cc=discuss@x86-64.org \
--cc=haveblue@us.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kmannth@us.ibm.com \
--cc=lhms-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®