From: Nathan Scott <nathans@sgi.com>
To: Joe Jin <lkmaillist@gmail.com>
Cc: kernel <linux@idccenter.cn>,
jdi@l4x.org, linux-kernel@vger.kernel.org, rdunlap@xenotime.net,
wim.coekaerts@oracle.com
Subject: Re: XFS Bug null pointer dereference in xfs_free_ag_extent
Date: Mon, 31 Jul 2006 19:53:54 +1000 [thread overview]
Message-ID: <20060731195354.B2301615@wobbly.melbourne.sgi.com> (raw)
In-Reply-To: <215036450607310141j4649c048t25ae45f2b7ed75@mail.gmail.com>; from lkmaillist@gmail.com on Mon, Jul 31, 2006 at 04:41:28PM +0800
On Mon, Jul 31, 2006 at 04:41:28PM +0800, Joe Jin wrote:
> At XFS have a debug option, but I wonder why why it was not opened,
> and you may open the option with follow patch, rebuild kernel, you
> maybe get more information of it.
> And when I trace the code, I also found at some function should check
> the return value, it also include the patch.
Hmmm. If you want to enable debug, theres an "official" patch in
the XFS CVS tree for doing so ... this patch has one or two minor
issues:
+config XFS_DEBUG
+ bool "XFS debugging"
+ depends on XFS_FS
+ help
+ If you are experiencing any problems with the XFS filesystem, say
+ Y here. This will result in additional debugging messages to be
+ written to the system log.
Thats not really what it does - it actually mostly enables asserts
all over the code, which cause the system to panic if something bad
is detected.
I don't expect the XFS debug code to help in this particular situation
in fact it may well hide the problem.
+ Under normal circumstances, this
+ results in very little overhead.
Its actually quite expensive. This is one of the reasons the enabling
patch isn't in mainline, as people switch it on and wonder what happened
to their performance numbers (also it is more useful with kdb).
cur = kmem_zone_zalloc(xfs_btree_cur_zone, KM_SLEEP);
+ if(!cur)
+ return NULL;
This can never happen due to the alloc flags argument.
--- linux-2.6.18-rc3/fs/xfs/xfs_alloc.c 2006-07-30 14:15:36.000000000 +0800
+++ linux.new/fs/xfs/xfs_alloc.c 2006-07-31 16:09:04.000000000 +0800
@@ -649,6 +649,9 @@
*/
bno_cur = xfs_btree_init_cursor(args->mp, args->tp, args->agbp,
args->agno, XFS_BTNUM_BNO, NULL, 0);
+ if(!bno_cur)
+ return XFS_ERROR(ENOMEM);
This also should never happen. From my reading of the oops report,
the problem is inside xfs_btree_init_cursor, I think from one of the
buffer pointers being null when it shouldn't be, but I'd like to get
it reproduced locally to be sure.
cheers.
--
Nathan
next prev parent reply other threads:[~2006-07-31 9:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-20 6:59 Jan Dittmer
2006-07-29 7:19 ` kernel
2006-07-29 7:49 ` Jan Dittmer
2006-07-29 8:10 ` kernel
2006-07-30 23:44 ` Nathan Scott
2006-07-31 1:30 ` kernel
2006-07-31 6:21 ` kernel
2006-07-31 6:55 ` Nathan Scott
2006-07-31 7:28 ` kernel
2006-07-31 8:41 ` Joe Jin
2006-07-31 9:53 ` Nathan Scott [this message]
2006-07-31 9:43 ` Nathan Scott
2006-07-31 10:04 ` kernel
[not found] ` <215036450607311849o43b1555br13ea2f3f20fb3b82@mail.gmail.com>
2006-08-01 8:12 ` Jan Dittmer
2006-08-02 1:26 ` Nathan Scott
2006-08-08 3:30 ` Nathan Scott
2006-07-31 6:58 ` Jan Dittmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060731195354.B2301615@wobbly.melbourne.sgi.com \
--to=nathans@sgi.com \
--cc=jdi@l4x.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@idccenter.cn \
--cc=lkmaillist@gmail.com \
--cc=rdunlap@xenotime.net \
--cc=wim.coekaerts@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®