From: Zach Brown <zach.brown@oracle.com>
To: linux-aio@kvack.org, linux-kernel@vger.kernel.org
Cc: Benjamin LaHaise <bcrl@kvack.org>, Andrew Morton <akpm@osdl.org>
Subject: [PATCH] [AIO] remove unused aio_run_iocbs()
Date: Mon, 31 Jul 2006 15:12:29 -0700 (PDT) [thread overview]
Message-ID: <20060731221229.18058.82700.sendpatchset@tetsuo.zabbo.net> (raw)
[AIO] remove unused aio_run_iocbs()
Nothing is calling the aio_run_iocbs() variant of *aio_run_*iocb*(). Let's try
and make life just a little less complicated by getting rid of it.
Signed-off-by: Zach Brown <zach.brown@oracle.com>
---
fs/aio.c | 21 ++-------------------
1 file changed, 2 insertions(+), 19 deletions(-)
Index: 2.6.18-rc3-trivialaio/fs/aio.c
===================================================================
--- 2.6.18-rc3-trivialaio.orig/fs/aio.c
+++ 2.6.18-rc3-trivialaio/fs/aio.c
@@ -814,30 +814,13 @@ static void aio_queue_work(struct kioctx
queue_delayed_work(aio_wq, &ctx->wq, timeout);
}
-
/*
- * aio_run_iocbs:
+ * aio_run_all_iocbs:
* Process all pending retries queued on the ioctx
- * run list.
+ * run list. It will retry until the list stays empty.
* Assumes it is operating within the aio issuer's mm
* context.
*/
-static inline void aio_run_iocbs(struct kioctx *ctx)
-{
- int requeue;
-
- spin_lock_irq(&ctx->ctx_lock);
-
- requeue = __aio_run_iocbs(ctx);
- spin_unlock_irq(&ctx->ctx_lock);
- if (requeue)
- aio_queue_work(ctx);
-}
-
-/*
- * just like aio_run_iocbs, but keeps running them until
- * the list stays empty
- */
static inline void aio_run_all_iocbs(struct kioctx *ctx)
{
spin_lock_irq(&ctx->ctx_lock);
next reply other threads:[~2006-07-31 22:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-31 22:12 Zach Brown [this message]
2006-08-01 7:27 ` Suparna Bhattacharya
2006-08-01 16:14 ` Zach Brown
2006-08-02 8:09 ` Suparna Bhattacharya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060731221229.18058.82700.sendpatchset@tetsuo.zabbo.net \
--to=zach.brown@oracle.com \
--cc=akpm@osdl.org \
--cc=bcrl@kvack.org \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®