mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chuck Ebbert <76306.1226@compuserve.com>
To: "akpm@osdl.org" <akpm@osdl.org>
Cc: zach@vmware.com, rohitseth@google.com, JBeulich@novell.com,
	ak@muc.de, stsp@aknet.ru,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: + espfix-code-cleanup.patch added to -mm tree
Date: Mon, 31 Jul 2006 22:24:47 -0400	[thread overview]
Message-ID: <200607312226_MC3-1-C6A9-1757@compuserve.com> (raw)

In-Reply-To: <200607300016.k6U0GYu4023664@shell0.pdx.osdl.net>

On Sat, 29 Jul 2006 17:16:34 -0700, Andrew Morton wrote:

>     espfix-code-cleanup.patch

After the fixup code does this:

       movl %esp, %eax         # pt_regs pointer
       movl %esp, %edx
       call patch_espfix_gdt
       pushl $__ESPFIX_SS
       CFI_ADJUST_CFA_OFFSET 4
       pushl %eax
       CFI_ADJUST_CFA_OFFSET 4
==>    lss (%esp), %esp
       CFI_ADJUST_CFA_OFFSET -8
       jmp restore_nocheck

we are on a ring0 32-bit stack that's not zero-based.  If an exception
occurs in that state, UNWIND_ESPFIX_STACK restores the proper kernel
SS and ESP but on return from the exception nothing restores the espfix
stack.  I guess this isn't a problem now because exceptions in kernel
mode are fatal but a kernel debugger might have problems here?

-- 
Chuck

             reply	other threads:[~2006-08-01  2:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-01  2:24 Chuck Ebbert [this message]
2006-08-01 12:39 ` Stas Sergeev
     [not found] <200607300016.k6U0GYu4023664@shell0.pdx.osdl.net>
     [not found] ` <44CE766D.6000705@vmware.com>
2006-08-01 12:21   ` Stas Sergeev
2006-08-01 13:38     ` Jan Beulich
2006-08-01 14:37       ` Stas Sergeev
2006-08-01 14:43         ` Jan Beulich
2006-08-01 15:09           ` Stas Sergeev
2006-08-01 21:01     ` Zachary Amsden
2006-08-02 17:12       ` Stas Sergeev
2006-08-02 18:30         ` Zachary Amsden
2006-08-02 19:12           ` Stas Sergeev
2006-08-02 19:14 Chuck Ebbert
2006-08-02 19:31 ` Stas Sergeev
2006-08-12  2:27 Chuck Ebbert
2006-08-12 10:35 ` Stas Sergeev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200607312226_MC3-1-C6A9-1757@compuserve.com \
    --to=76306.1226@compuserve.com \
    --cc=JBeulich@novell.com \
    --cc=ak@muc.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rohitseth@google.com \
    --cc=stsp@aknet.ru \
    --cc=zach@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®