From: Andrew Morton <akpm@osdl.org>
To: Jan Blunck <jblunck@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix vmstat per cpu usage
Date: Tue, 1 Aug 2006 14:07:07 -0700 [thread overview]
Message-ID: <20060801140707.a55a0513.akpm@osdl.org> (raw)
In-Reply-To: <20060801173620.GM4995@hasse.suse.de>
On Tue, 1 Aug 2006 19:36:21 +0200
Jan Blunck <jblunck@suse.de> wrote:
> The per cpu variables are used incorrectly in vmstat.h.
>
> Signed-off-by: Jan Blunck <jblunck@suse.de>
> ---
> include/linux/vmstat.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> Index: linux-v2.6.18-rc3/include/linux/vmstat.h
> ===================================================================
> --- linux-v2.6.18-rc3.orig/include/linux/vmstat.h
> +++ linux-v2.6.18-rc3/include/linux/vmstat.h
> @@ -41,23 +41,23 @@ DECLARE_PER_CPU(struct vm_event_state, v
>
> static inline void __count_vm_event(enum vm_event_item item)
> {
> - __get_cpu_var(vm_event_states.event[item])++;
> + __get_cpu_var(vm_event_states).event[item]++;
> }
How odd. Are there any negative consequences to the existing code?
next prev parent reply other threads:[~2006-08-01 21:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-01 17:36 Jan Blunck
2006-08-01 21:07 ` Andrew Morton [this message]
2006-08-01 22:44 ` Paul Mackerras
2006-08-02 9:01 ` Jan Blunck
2006-08-02 13:30 ` Jan Blunck
2006-08-02 14:43 ` Andrew Morton
2006-08-07 12:42 ` Jan Blunck
2006-08-02 16:54 ` Steve Fox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060801140707.a55a0513.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=jblunck@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®