From: Dave Jones <davej@redhat.com>
To: akpm@osdl.org
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: clear vm_reclaimable when we free pages.
Date: Tue, 1 Aug 2006 13:57:16 -0400 [thread overview]
Message-ID: <20060801175716.GB22240@redhat.com> (raw)
There are two places where we reclaim free pages, but we never
update the all_unreclaimable flag for the relevant zone.
This patch helped reduce the frequency of oom-kills under high load
for us a while back, and we've been carrying it since.
I posted this a few months back and from what I recall it didn't
get a great deal of interest.
Signed-off-by: Dave Jones <davej@redhat.com>
--- linux-2.6/mm/filemap.c~ 2005-12-10 01:47:15.000000000 -0500
+++ linux-2.6/mm/filemap.c 2005-12-10 01:47:46.000000000 -0500
@@ -471,11 +471,18 @@ EXPORT_SYMBOL(unlock_page);
*/
void end_page_writeback(struct page *page)
{
+ struct zone *zone = page_zone(page);
if (!TestClearPageReclaim(page) || rotate_reclaimable_page(page)) {
if (!test_clear_page_writeback(page))
BUG();
}
smp_mb__after_clear_bit();
+ if (zone->all_unreclaimable) {
+ spin_lock(&zone->lock);
+ zone->all_unreclaimable = 0;
+ zone->pages_scanned = 0;
+ spin_unlock(&zone->lock);
+ }
wake_up_page(page, PG_writeback);
}
EXPORT_SYMBOL(end_page_writeback);
--- linux-2.6/mm/page_alloc.c~ 2006-01-09 13:40:03.000000000 -0500
+++ linux-2.6/mm/page_alloc.c 2006-01-09 13:40:50.000000000 -0500
@@ -722,6 +722,11 @@ static void fastcall free_hot_cold_page(
if (pcp->count >= pcp->high) {
free_pages_bulk(zone, pcp->batch, &pcp->list, 0);
pcp->count -= pcp->batch;
+ } else if (zone->all_unreclaimable) {
+ spin_lock(&zone->lock);
+ zone->all_unreclaimable = 0;
+ zone->pages_scanned = 0;
+ spin_unlock(&zone->lock);
}
local_irq_restore(flags);
put_cpu();
--
http://www.codemonkey.org.uk
next reply other threads:[~2006-08-01 17:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-01 17:57 Dave Jones [this message]
2006-08-02 5:48 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060801175716.GB22240@redhat.com \
--to=davej@redhat.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®