mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@sous-sol.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Jeremy Fitzhardinge <jeremy@xensource.com>,
	akpm@osdl.org, linux-kernel@vger.kernel.org,
	Chris Wright <chrisw@sous-sol.org>,
	Christian Limpach <Christian.Limpach@cl.cam.ac.uk>,
	Christoph Lameter <clameter@sgi.com>,
	Gerd Hoffmann <kraxel@suse.de>,
	Hollis Blanchard <hollisb@us.ibm.com>,
	Ian Pratt <ian.pratt@xensource.com>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Zachary Amsden <zach@vmware.com>
Subject: Re: [PATCH 1 of 13] Add apply_to_page_range() which applies a function to a pte range
Date: Tue, 1 Aug 2006 14:14:10 -0700	[thread overview]
Message-ID: <20060801211410.GH2654@sequoia.sous-sol.org> (raw)
In-Reply-To: <m1ejw0zmic.fsf@ebiederm.dsl.xmission.com>

* Eric W. Biederman (ebiederm@xmission.com) wrote:
> - You don't handle huge pages.  For a generic function
>   that sounds like a problem.
> - I believe there is a reason the kernel doesn't already have
>   a function like this.  I seem to recall there being efficiency
>   and fast path arguments.
> - Placing this code in mm/memory.c without a common consumer is
>   pure kernel bloat for everyone who doesn't use this function,
>   which is just about everyone.

We got the opposite feedback the first time we posted this function.
Xen has some users, and I believe there's a couple in-tree functions we could
convert easily w/out overhead issues.  It's generic and this is just the
infrastructure, I think we should leave it.

thanks,
-chris

  parent reply	other threads:[~2006-08-01 21:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <79a98a10911fc4e77dce.1154421372@ezr.goop.org>
2006-08-01 12:08 ` Eric W. Biederman
2006-08-01 12:34   ` Antonio Vargas
2006-08-01 21:14   ` Chris Wright [this message]
2006-08-01 21:31     ` Christoph Lameter
2006-08-02  4:16       ` Rusty Russell
2006-08-02  5:18         ` Christoph Lameter
2006-08-02  6:44           ` Ian Wienand
2006-08-02  6:54             ` Chris Wright
2006-08-02 13:17               ` Paul Cameron Davies

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060801211410.GH2654@sequoia.sous-sol.org \
    --to=chrisw@sous-sol.org \
    --cc=Christian.Limpach@cl.cam.ac.uk \
    --cc=akpm@osdl.org \
    --cc=clameter@sgi.com \
    --cc=ebiederm@xmission.com \
    --cc=hollisb@us.ibm.com \
    --cc=ian.pratt@xensource.com \
    --cc=jeremy@xensource.com \
    --cc=kraxel@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=zach@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome