From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: 76306.1226@compuserve.com, andros@citi.umich.edu,
orion@cora.nwra.com, linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: fctnl(F_SETSIG) no longer works in 2.6.17, does in 2.6.16.
Date: Wed, 2 Aug 2006 00:51:57 +1000 [thread overview]
Message-ID: <20060802005157.137dfdde.sfr@canb.auug.org.au> (raw)
In-Reply-To: <1154370233.8417.11.camel@localhost>
On Mon, 31 Jul 2006 11:23:52 -0700 Trond Myklebust <trond.myklebust@fys.uio.no> wrote:
>
> On Mon, 2006-07-31 at 02:21 -0400, Chuck Ebbert wrote:
>
> > static void lease_release_private_callback(struct file_lock *fl)
> > {
> > if (!fl->fl_file)
> > return;
> >
> > f_delown(fl->fl_file);
> > => fl->fl_file->f_owner.signum = 0;
> > }
>
> Why should the lease cleanup code be resetting f_owner.signum? That
> looks wrong.
>
> Stephen, I think this line of code predates the CITI changes. Do you
> know who added it and why?
Because when the original code was written, it was only called when we got
a fcntl(F_SETLEASE, F_UNLCK) call. The code got moved incorrectly and
noone noticed.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
next prev parent reply other threads:[~2006-08-01 14:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-31 6:21 Chuck Ebbert
2006-07-31 18:23 ` Trond Myklebust
2006-08-01 14:51 ` Stephen Rothwell [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-08-08 5:38 Beschorner Daniel
2006-08-08 13:26 ` Trond Myklebust
2006-08-09 8:39 ` Beschorner Daniel
2006-07-27 22:08 Orion Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060802005157.137dfdde.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=76306.1226@compuserve.com \
--cc=akpm@osdl.org \
--cc=andros@citi.umich.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=orion@cora.nwra.com \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®